fix(appstore): use URL-safe base64 encoding for user content proxy URLs - #63139
Open
edward-ly wants to merge 1 commit into
Open
fix(appstore): use URL-safe base64 encoding for user content proxy URLs#63139edward-ly wants to merge 1 commit into
edward-ly wants to merge 1 commit into
Conversation
Signed-off-by: Edward Ly <contact@edward.ly>
edward-ly
force-pushed
the
fix/noid/usercontent-base64-urlencode
branch
from
August 11, 2026 14:29
e9e3e1d to
9804988
Compare
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
edward-ly
marked this pull request as ready for review
August 11, 2026 15:52
edward-ly
requested review from
leftybournes,
provokateurin,
salmart-dev and
sorbaugh
and removed request for
a team
August 11, 2026 15:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some app screenshot URLs in the proxy server may include the '/' character in their base64 encoding, but since '/' is a prohibited character for file names, the computed proxy server URL was invalid and such screenshots would fail to be retrieved (or rather, the screenshots weren't saved to begin with because of this).
Accompanies nextcloud/usercontent.apps.nextcloud.com#25.
Checklist
3. to review, feature component)stable32)