fix(appstore): honor subclass cache invalidation duration in fetchers - #63131
Open
joshtrichards wants to merge 1 commit into
Open
fix(appstore): honor subclass cache invalidation duration in fetchers#63131joshtrichards wants to merge 1 commit into
joshtrichards wants to merge 1 commit into
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
leftybournes and
provokateurin
and removed request for
a team
August 10, 2026 14:47
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
susnux
approved these changes
Aug 10, 2026
CarlSchwan
enabled auto-merge
August 10, 2026 15:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #Summary
AppDiscoverFetcherdeclares:However, the base class (
Fetcher) usesself::INVALIDATE_AFTER_SECONDS, causingAppDiscoverFetcher's override value to be ignored.Therefore the discover fetcher does not actually use 24 hours through this mechanism; it still uses the base class’s one-hour/15-minute thresholds.
Changes:
INVALIDATE_AFTER_SECONDS.Allows
AppDiscoverFetcherto use its existing 24-hour cache duration override as (presumably) intended. Preserves the existing default duration for fetchers that do not override the constant.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)