feat: add option to send legacy style x-amx-user-agent header to s3 server - #63121
Draft
icewind1991 wants to merge 1 commit into
Draft
feat: add option to send legacy style x-amx-user-agent header to s3 server#63121icewind1991 wants to merge 1 commit into
icewind1991 wants to merge 1 commit into
Conversation
…erver Signed-off-by: Robin Appelman <robin@icewind.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starting with aws-sdk 3.336.0, the user agent headers sent by the sdk have changed.
Previously, the
X-Amz-User-AgentandUser-Agentheader would both contain the same user agent.Since 3.336.0, the
X-Amz-User-Agentno longer contains the user agent but is sent empty instead.This seems to break some s3 implementations, so we can add a middleware to re-add the value
TODO:
Checklist
3. to review, feature component)stable32)AI (if applicable)