Skip to content

feat: add option to send legacy style x-amx-user-agent header to s3 server - #63121

Draft
icewind1991 wants to merge 1 commit into
masterfrom
s3-legacy-ua-header
Draft

feat: add option to send legacy style x-amx-user-agent header to s3 server#63121
icewind1991 wants to merge 1 commit into
masterfrom
s3-legacy-ua-header

Conversation

@icewind1991

@icewind1991 icewind1991 commented Aug 10, 2026

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

Starting with aws-sdk 3.336.0, the user agent headers sent by the sdk have changed.

Previously, the X-Amz-User-Agent and User-Agent header would both contain the same user agent.

Since 3.336.0, the X-Amz-User-Agent no longer contains the user agent but is sent empty instead.

This seems to break some s3 implementations, so we can add a middleware to re-add the value

TODO:

  • Verify that this fixes the issue with the problematic s3 implementation
  • Document the config flag

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

…erver

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added this to the Nextcloud 35 milestone Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant