Skip to content

Fix errors from 32bits CI - #63114

Open
come-nc wants to merge 6 commits into
masterfrom
fix/fix-32bits-support-35
Open

Fix errors from 32bits CI#63114
come-nc wants to merge 6 commits into
masterfrom
fix/fix-32bits-support-35

Conversation

@come-nc

@come-nc come-nc commented Aug 10, 2026

Copy link
Copy Markdown
Contributor
  • Resolves: #

Summary

Fixes failures from our 32bits CI job.
One issue was the last_updated field in sharing that stores a timestamp in milliseconds into an int, which does not fit. So using string for this instead, same idea as for snowflake ids.
The second issue was snowflake ids sometimes being used with PARAM_INT_ARRAY in IN query builder function.
The third one was a typo in ServerInfo which made the ternary backward.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@come-nc come-nc self-assigned this Aug 10, 2026
@come-nc come-nc added the 2. developing Work in progress label Aug 10, 2026
@come-nc

come-nc commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

@come-nc
come-nc force-pushed the fix/fix-32bits-support-35 branch from 77604da to 45d49cd Compare August 11, 2026 07:00
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 11, 2026
@come-nc come-nc added this to the Nextcloud 35 milestone Aug 11, 2026
@come-nc
come-nc marked this pull request as ready for review August 11, 2026 07:04
@come-nc
come-nc requested review from a team and provokateurin as code owners August 11, 2026 07:04
@come-nc
come-nc requested review from icewind1991, leftybournes and sorbaugh and removed request for a team August 11, 2026 07:04
@come-nc
come-nc force-pushed the fix/fix-32bits-support-35 branch 3 times, most recently from 4a20631 to 1c9b48b Compare August 11, 2026 07:49
Same strategy as for snowflake ids.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Only PHP 8.4 is tested because we use our own image

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
That helps when testing locally with nektos/act

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
The ternary was reversed because of this typo.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
come-nc force-pushed the fix/fix-32bits-support-35 branch from 1c9b48b to fe96dd9 Compare August 11, 2026 08:14
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
come-nc force-pushed the fix/fix-32bits-support-35 branch from 6297d50 to d9867d7 Compare August 11, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant