refactor(files_trashbin): Clean up move2trash and expand test coverage - #63069
Draft
joshtrichards wants to merge 4 commits into
Draft
refactor(files_trashbin): Clean up move2trash and expand test coverage#63069joshtrichards wants to merge 4 commits into
joshtrichards wants to merge 4 commits into
Conversation
Flatten logic: 1. If there is not enough space, stop. 2. Copy the item. 3. If the copy did not materialize, stop. 4. Record metadata. 5. If bookkeeping fails, log the error, stop. Clarify cross-user copy method: - existing copyFilesToUser() docblock is vague - does not explain why it exists / how failures are handled Signed-off-by: Josh <josh.t.richards@gmail.com>
…2Trash Also null check style improvements and make some useful but focused comment improvements: - Explain why the timestamp is incremented - Clarify the database-before-move ordering - Explain the cache update branches - Clarify the failed-original-deletion recovery - Improve the owner/user comments - Update the move2Trash() docblock Signed-off-by: Josh <josh.t.richards@gmail.com>
- Configured size fallback: source remains, no trash item is created. - Shared deletion: both owner and deleting user receive trash entries. Assisted-by: Copilot:gpt-5.6-luna Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
2. developing
Signed-off-by: Josh <josh.t.richards@gmail.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change primarily improves readability and documentation in the
Trashbin::move2Trash()implementation while adding additional coverage for shared-file deletion and configured trashbin size limits.Changes:
post_moveToTrashhook invocation for readability.Behavior
The changes are primarily comment cleanup, type clarification, and additional test coverage. The tests document expected behavior around shared files and configured trashbin limits.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)