test(files): expand and improve quota wrapper coverage - #63035
Draft
joshtrichards wants to merge 3 commits into
Draft
test(files): expand and improve quota wrapper coverage#63035joshtrichards wants to merge 3 commits into
joshtrichards wants to merge 3 commits into
Conversation
Remove the invalid existing-directory mkdir assertion, cover exact quota boundaries for writes, and verify successful writeStream results and cleanup. Assisted-by: Copilot:gpt-5.6-luna Signed-off-by: Josh <josh.t.richards@gmail.com>
Cover quota callbacks, unlimited and disabled quotas, negative quotas, bypass paths, part files, sized streams, and cross-storage operations. Signed-off-by: Josh <josh.t.richards@gmail.com>
Verify that the quota wrapper includes files from mounted external storage when `include_external_storage` is enabled. Assisted-by: Copilot:gpt-5.6-luna Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes some existing test bugs for
OC\Files\Storage\Wrapper\Quotaand expands targeted PHPUnit coverage focusing on previously-untested branches and quota- boundary behavior.Notes
New coverage:
file_put_contents/writeStreamreject exact-fit writes due to current strict<comparison)quotaCallbackinvocation and caching (getQuota()only calls the callback once)FileInfo::SPACE_UNLIMITED) and negative quota values delegate to wrapped storageenableQuota(false)disables enforcementcache/anduploads/path prefixes bypass quota.partfiles bypass quota when opened for writingcopyFromStorage/moveFromStoragecorrectly reject and leave source/target untouched when quota is exceededwriteStream()return values and exact-limit rejection (previously the return value wasn't asserted)include_external_storagequota accounting correctly reflects mounted external storage infree_space()Fix:
testNoMkdirQuotaZero()(assertFalse($instance->mkdir('files'))). This was passing for the wrong reason:getLimitedStorage()already createsfiles/on the underlying storage before the test runs. In addition,shouldApplyQuota()only applies quota to paths matchingfiles/(with trailing slash), so barefileswas never quota-scoped to begin with.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)