fix(NavigationManager): properly register closures - #62988
Merged
Conversation
susnux
requested review from
icewind1991,
leftybournes,
nfebe and
sorbaugh
and removed request for
a team
August 6, 2026 20:40
CarlSchwan
approved these changes
Aug 7, 2026
CarlSchwan
force-pushed
the
fix/navigation-manager-init
branch
from
August 7, 2026 07:42
8a712cb to
314cccb
Compare
come-nc
approved these changes
Aug 11, 2026
Lately there were quite some issues with the NavigationManager, so this tries to clarifies the implementation a bit. But more important this fixes an issue when closures are registered after the setup was already done (see added unit test). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/navigation-manager-init
branch
from
August 11, 2026 17:26
314cccb to
5084b58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lately there were quite some issues with the NavigationManager, so this tries to clarifies the implementation a bit. But more important this fixes an issue when closures are registered after the setup was already done (see added unit test).
This fixes the issue reported by @blizzz in tables - though table should instead move to the proper event.
Checklist
3. to review, feature component)stable32)AI (if applicable)