fix: allow file request upload when part_file_in_storage=false - #62986
Open
salmart-dev wants to merge 1 commit into
Open
fix: allow file request upload when part_file_in_storage=false#62986salmart-dev wants to merge 1 commit into
part_file_in_storage=false#62986salmart-dev wants to merge 1 commit into
Conversation
The part_file_in_storage option being disabled, causes files to be uploaded in the user's root, rather than in the final directory. This, in combination with the use of upload nicknames, was not detected by the patched check, causing uploads to check for the UPDATE permissions, which is not granted for file requests, making all uploads always fail. Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
salmart-dev
requested review from
Altahrim,
icewind1991,
leftybournes and
provokateurin
and removed request for
a team
August 6, 2026 16:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Setting the config value
part_file_in_storage=falseand trying to upload files in a file request, using local storage and providing a nickname always fail. The reason is that the storage wrapper fails to detect the case when the file gets uploaded in the root due to the configuration, failing the parent directory check and checking for the UPDATE permission instead of the CREATE one.Note: I am not sure that the fix is correct, as the config exists to improve compatibility with some storages and uploading files in the root of the storage wrapper, rather than the root of the view, could still cause issues in certain cases.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)