Skip to content

fix(files): Exclude file size of excluded files in personal files view - #62951

Open
rgroothuijsen wants to merge 1 commit into
nextcloud:masterfrom
rgroothuijsen:fix/issue-58423-personal-files-size
Open

fix(files): Exclude file size of excluded files in personal files view#62951
rgroothuijsen wants to merge 1 commit into
nextcloud:masterfrom
rgroothuijsen:fix/issue-58423-personal-files-size

Conversation

@rgroothuijsen

Copy link
Copy Markdown

Summary

The "Personal files" view filters group folders from the directory listing, but does not adjust the reported total size. This PR adjusts the file size after the folders have been filtered.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@rgroothuijsen
rgroothuijsen requested review from a team and skjnldsv as code owners August 5, 2026 15:42
@rgroothuijsen
rgroothuijsen requested review from kristian-zendato and sorbaugh and removed request for a team August 5, 2026 15:42

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is missing the SPDX headers, please add them

Comment thread apps/files/src/services/PersonalFiles.ts Outdated
Comment thread apps/files/src/services/PersonalFiles.ts Outdated
@susnux susnux added bug 3. to review Waiting for reviews feature: files team: Files Code maintained by 📁 Files team labels Aug 5, 2026
@susnux

susnux commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for the pull request! Only one real block: The missing SPDX headers.

@rgroothuijsen
rgroothuijsen force-pushed the fix/issue-58423-personal-files-size branch from c472ded to ba92520 Compare August 5, 2026 17:23
@susnux
susnux requested a review from nfebe August 5, 2026 21:08
@susnux

susnux commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

@rgroothuijsen can you please:

  1. rebase onto current master (git fetch --all && git rebase upstream/master)
  2. compile the assets (npm ci && npm run build)

@rgroothuijsen
rgroothuijsen requested a review from a team as a code owner August 6, 2026 14:09
@rgroothuijsen
rgroothuijsen requested review from come-nc, leftybournes and salmart-dev and removed request for a team August 6, 2026 14:09

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong during your rebase you committed too many unrelatd changes

@rgroothuijsen

Copy link
Copy Markdown
Author

Apologies, I think I messed up my branch by previously amending commits, so I got a warning recommending that I merge instead of rebasing. I can try rebasing again to see if that helps.

Signed-off-by: Rens Groothuijsen <l.groothuijsen@alumni.maastrichtuniversity.nl>
@rgroothuijsen
rgroothuijsen force-pushed the fix/issue-58423-personal-files-size branch from c3df0ff to a90b154 Compare August 6, 2026 15:43
@come-nc
come-nc removed their request for review August 7, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug feature: files team: Files Code maintained by 📁 Files team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Reported total size under personal files seems to include team folder size

3 participants