[stable30] chore(psalm): use full qualified class name for Circles - #62926
Merged
Conversation
The entire file is written in a way to ensure it also works if the circles app is not installed. So there is no `Circles` alias as it cannot be added with `use`. Signed-off-by: Max <max@nextcloud.com>
github-actions
Bot
changed the title
max-nextcloud
marked this pull request as ready for review
August 5, 2026 09:00
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
max-nextcloud
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
artonge
approved these changes
Aug 5, 2026
cristianscheid
approved these changes
Aug 5, 2026
CarlSchwan
approved these changes
Aug 5, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| try { | ||
| $member = Circles::getMember($sharedWith, $this->userId, 1); | ||
|
|
||
| $member = \OCA\Circles\Api\v1\Circles::getMember($sharedWith, $this->userId, 1); |
github-project-automation
Bot
moved this from 👀 In review
to ☑️ Done
in 📝 Productivity team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entire file is written in a way to ensure it also works
if the circles app is not installed.
So there is no
Circlesalias as it cannot be added withuse.This is only relevant for stable30 and before due as #48371 landed in stable31.