Skip to content

feat(webauthn): Skip 2FA for user verified logins - #62540

Open
mimi89999 wants to merge 1 commit into
nextcloud:masterfrom
mimi89999:feat/webauthn-skip-2fa
Open

feat(webauthn): Skip 2FA for user verified logins#62540
mimi89999 wants to merge 1 commit into
nextcloud:masterfrom
mimi89999:feat/webauthn-skip-2fa

Conversation

@mimi89999

Copy link
Copy Markdown

A WebAuthn login with user verification is already a second factor, so do not ask for an additional 2FA challenge

Summary

WebAuthn optionally performs user verification: a PIN or a fingerprint is checked on the device itself. That is effectively MFA, something the user has plus something the user knows.

This PR skips the 2FA challenge for those logins. Keys without user verification still go through the usual challenge.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@mimi89999
mimi89999 requested a review from a team as a code owner July 25, 2026 17:20
@mimi89999
mimi89999 requested review from Altahrim, leftybournes, provokateurin and salmart-dev and removed request for a team July 25, 2026 17:20
@mimi89999
mimi89999 force-pushed the feat/webauthn-skip-2fa branch from a1172e1 to cc13da9 Compare July 25, 2026 17:35
@susnux
susnux requested a review from ChristophWurst July 25, 2026 22:20
@mimi89999
mimi89999 force-pushed the feat/webauthn-skip-2fa branch from cc13da9 to df2051b Compare July 29, 2026 16:08
@mimi89999

Copy link
Copy Markdown
Author

@susnux is it expected that the check are failing for this PR?

@golemusu

Copy link
Copy Markdown

splendid. What is your estimate that if/when this is integrated to main branch how long it will actually take for the feature to be available for use e.g. for me (I am using Nextcloud in Hetzner, it seems to be a bit more conservative of server updates and updated just to 33.0.6) ?

So does it require updating the whole server or is it one of the plugins that just needs to be updated?

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

thanks for the PR

Comment thread core/Controller/WebAuthnController.php Outdated
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

A WebAuthn login with user verification is already a second factor,
so do not ask for an additional 2FA challenge

Signed-off-by: Michel Le Bihan <michel@lebihan.pl>
@mimi89999
mimi89999 force-pushed the feat/webauthn-skip-2fa branch from c88fbb0 to 25afab8 Compare August 9, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable 2FA when Webauthn is being used.

4 participants