feat(webauthn): Skip 2FA for user verified logins - #62540
Conversation
a1172e1 to
cc13da9
Compare
cc13da9 to
df2051b
Compare
|
@susnux is it expected that the check are failing for this PR? |
|
splendid. What is your estimate that if/when this is integrated to main branch how long it will actually take for the feature to be available for use e.g. for me (I am using Nextcloud in Hetzner, it seems to be a bit more conservative of server updates and updated just to 33.0.6) ? So does it require updating the whole server or is it one of the plugins that just needs to be updated? |
ChristophWurst
left a comment
There was a problem hiding this comment.
LGTM otherwise
thanks for the PR
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
df2051b to
c88fbb0
Compare
A WebAuthn login with user verification is already a second factor, so do not ask for an additional 2FA challenge Signed-off-by: Michel Le Bihan <michel@lebihan.pl>
c88fbb0 to
25afab8
Compare
A WebAuthn login with user verification is already a second factor, so do not ask for an additional 2FA challenge
Summary
WebAuthn optionally performs user verification: a PIN or a fingerprint is checked on the device itself. That is effectively MFA, something the user has plus something the user knows.
This PR skips the 2FA challenge for those logins. Keys without user verification still go through the usual challenge.
Checklist
3. to review, feature component)stable32)AI (if applicable)