Skip to content

[stable34] fix: Use PHP_AUTH_PW for strict password confirmation - #62537

Merged
SystemKeeper merged 2 commits into
stable34from
backport/62477/stable34
Aug 5, 2026
Merged

[stable34] fix: Use PHP_AUTH_PW for strict password confirmation#62537
SystemKeeper merged 2 commits into
stable34from
backport/62477/stable34

Conversation

@backportbot

@backportbot backportbot Bot commented Jul 25, 2026

Copy link
Copy Markdown

Backport of #62477

For easier testing in the community, since master cannot be directly applied.

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Review and verify the backported changes
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
backportbot Bot requested a review from SystemKeeper July 25, 2026 13:16
@backportbot backportbot Bot added bug 3. to review Waiting for reviews feature: authentication php Pull requests that update Php code 34-feedback labels Jul 25, 2026
@backportbot backportbot Bot added this to the Nextcloud 34.0.3 milestone Jul 25, 2026
@SystemKeeper
SystemKeeper force-pushed the backport/62477/stable34 branch from 3a40951 to b737ad2 Compare July 25, 2026 13:37
@Volker-K

Copy link
Copy Markdown

Checked it quick and dirty in 33.0.3.2 and it fixed the problem.
Thank you.

@SystemKeeper
SystemKeeper force-pushed the backport/62477/stable34 branch from b737ad2 to 9c2ae17 Compare July 29, 2026 17:59
@SystemKeeper

Copy link
Copy Markdown
Contributor

/backport to stable33

@SystemKeeper

Copy link
Copy Markdown
Contributor

/backport to stable32

@SystemKeeper
SystemKeeper marked this pull request as ready for review July 29, 2026 19:15
@SystemKeeper
SystemKeeper requested a review from a team as a code owner July 29, 2026 19:15
@SystemKeeper
SystemKeeper requested review from come-nc, icewind1991, nfebe, provokateurin, sorbaugh and susnux and removed request for a team July 29, 2026 19:15

@come-nc come-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dislike getting this though getHeader, it’s not a header per-se, is it?

It looks like the rest of the code uses $this->request->server['PHP_AUTH_USER'], which is ugly.
Would it make sense to have dedicated getters to get user and password from basic auth?

@SystemKeeper

Copy link
Copy Markdown
Contributor

@come-nc I think that’s generally a good idea. I would even go one step further and remove the special key handling completely?

since this is breaking, we should do it starting with 35? The only tricky one I can see right now is

$remoteAddress = $this->request->getHeader('REMOTE_ADDR');
$detectedRemoteAddress = $this->request->getRemoteAddress();

to fix the linked issue, shall we therefore merge this?

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
SystemKeeper force-pushed the backport/62477/stable34 branch from 9c2ae17 to 779dc1a Compare August 5, 2026 15:04
@SystemKeeper
SystemKeeper merged commit d8c8e42 into stable34 Aug 5, 2026
179 checks passed
@SystemKeeper
SystemKeeper deleted the backport/62477/stable34 branch August 5, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews 34-feedback bug feature: authentication php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants