feat(federation): implement minimal federation user backend - #62471
feat(federation): implement minimal federation user backend#62471leftybournes wants to merge 1 commit into
Conversation
Signed-off-by: Kent Delante <kent@delante.me>
leftybournes
added
enhancement
3. to review
|
Tests are related. I'm looking into it. |
| } | ||
|
|
||
| #[\Override] | ||
| public function hasUserListings() { |
There was a problem hiding this comment.
need return types for every of these methods and parameter types for the methods where it is defined in IUserBackend/UserInterface
| } | ||
|
|
||
| #[\Override] | ||
| public function getDisplayNames($search = '', $limit = null, $offset = null) { |
There was a problem hiding this comment.
It's better to leave the default implementation from ABackend than returning an empty array
And ideally a proper implementation of this method is implemented based on a new method ICloudIdManager::resolveCloudIds(array $ids);
|
I tried working on this but it seems to increase the complexity just to fix the "deleted-by" issue for federated shares. It causes issues with guest accounts and e-mail address usernames. I worked on a new PR that directly fixes the "deleted-by" issue with federated shares in #62925 |
|
Closing in favor of the PR mentioned above. |
2 participants
Summary
This adds a minimal user backend for federation that can continue to be built upon.
This was inspired by and fixes an issue where the "Deleted by" column in the trashbin is shown as "Unknown" if a file shared externally was deleted by a remote user. The "Deleted by" column will now correctly show the federated user as the deleter (e.g. bob@example.com)
Checklist
3. to review, feature component)stable32)AI (if applicable)