fix(share): do not re-accept rejected shares - #62373
Merged
Merged
Conversation
ArtificialOwl
requested review from
Altahrim,
come-nc,
leftybournes and
nfebe
and removed request for
a team
July 21, 2026 18:50
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
come-nc
approved these changes
Aug 3, 2026
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
fix/noid/keep-hidden-share-as-hidden
branch
from
August 4, 2026 11:08
265556c to
f74556b
Compare
artonge
approved these changes
Aug 4, 2026
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems owncloud is using the 'accepted' field on share_type=(0, 1, 2) to delete shares - instead of deleting the entry from
oc_sharelike we do. This way, even user-to-user direct share can be restored via the 'Deleted shares' panel in Files.Now, during the migration from oc to nc, we flatten the value to 1 forcing previously deleted shares to come back to life.
This patch will flatten value to 1 only on non-rejected shares.
This patch should be backport to 31 as migration can be initiated to 31