fix: allow Enter on public share Download link - #62367
Conversation
|
/backport to stable34 |
|
/backport to stable33 |
susnux
left a comment
There was a problem hiding this comment.
looks good, but ESLint needs to be resolved
aa61dbf to
769773c
Compare
769773c to
777c012
Compare
Signed-off-by: Kristian Zendato <kristian.zendato@nextcloud.com>
777c012 to
706c8f5
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
On public shares, the header Download control is an
<a>that can be focused with the keyboard, but Enter did not start the download.Cause: each
FileEntryregistered an Enter hotkey withprevent: true/stop: true.useHotKeyalways calledpreventDefaultbefore the callback, so Enter was cancelled even when the row was inactive and did nothing.Change: only call
preventDefault/stopPropagationinsidetriggerDefaultActionwhen the row is active. Browser default activation of the Download link works again.Added a Cypress regression test that focuses Download and presses Enter.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)