Don't fill the pagination cache if there are no extra items - #62365
Merged
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
Altahrim,
come-nc,
nfebe and
salmart-dev
and removed request for
a team
July 21, 2026 12:59
icewind1991
changed the title
come-nc
approved these changes
Aug 3, 2026
Comment on lines
+56
to
+58
| public function hasOthers(): bool { | ||
| return $this->hasOthers; | ||
| } |
Contributor
There was a problem hiding this comment.
It’s crazy, I was convinced it was not legal to name a property and a function exactly the same, but it appears it’s always been allowed by PHP…
Today I learned 💡
susnux
approved these changes
Aug 3, 2026
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Only store paginated items and return pagination headers if the requested folder has more than 1 page worth of items.
This prevents needlessly caching items in redis
Checklist
3. to review, feature component)stable32)AI (if applicable)