fix(core): prevent double-submit on login flow grant page - #62357
Conversation
Add isSubmitting guard to onSubmit so the button is disabled and shows a loading spinner as soon as the first submit fires. A second click while the form is in-flight is dropped via event.preventDefault(). Fixes: nextcloud#62327 Assisted-by: ClaudeCode:claude-sonnet-4-6
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@okxint please fix the linter issues ( |
Fixes #62327
The Vue rewrite of
LoginFlowGrantdropped the disable-on-submit guard that existed in the oldgrant.js(added in #33164). Without it, Chrome's double-fire behavior or a fast second click sends two POST requests before the first response arrives, which can result in duplicate grant confirmations.Fix: add an
isSubmittingref that blocks re-entry intoonSubmitand disables the button while the request is in flight. ANcLoadingIconis shown in the#iconslot during submission, following the same pattern used inPublicPageMenuExternalDialog.vue.