Skip to content

feat(files_sharing): fetch remote avatars for external shares - #62355

Merged
sorbaugh merged 2 commits into
masterfrom
leftybournes/feat/federatedshares-show-avatars
Aug 6, 2026
Merged

feat(files_sharing): fetch remote avatars for external shares#62355
sorbaugh merged 2 commits into
masterfrom
leftybournes/feat/federatedshares-show-avatars

Conversation

@leftybournes

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

Currently, external shares always show a GuestAvatar in the files list. This adds functionality to fetch the remote sharer's avatar.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@leftybournes leftybournes added this to the Nextcloud 35 milestone Jul 21, 2026
@leftybournes
leftybournes requested a review from a team as a code owner July 21, 2026 05:35
@leftybournes
leftybournes requested review from Altahrim, come-nc, nfebe and salmart-dev and removed request for a team July 21, 2026 05:35
@leftybournes
leftybournes force-pushed the leftybournes/feat/federatedshares-show-avatars branch from e064efd to b8f517f Compare July 21, 2026 05:47
@leftybournes
leftybournes force-pushed the leftybournes/feat/federatedshares-show-avatars branch 2 times, most recently from 5f1c880 to a17c574 Compare July 21, 2026 06:20
Comment thread lib/private/Avatar/RemoteAvatar.php
Comment thread lib/private/Avatar/RemoteAvatar.php Outdated
@leftybournes
leftybournes force-pushed the leftybournes/feat/federatedshares-show-avatars branch from a17c574 to 318668e Compare July 22, 2026 08:54
@leftybournes
leftybournes force-pushed the leftybournes/feat/federatedshares-show-avatars branch from 318668e to 7551692 Compare July 23, 2026 02:33
Comment thread lib/private/Avatar/RemoteAvatar.php Outdated
@CarlSchwan

Copy link
Copy Markdown
Member

failing tests

Comment thread lib/private/Avatar/AvatarManager.php Outdated
Comment thread lib/private/Avatar/AvatarManager.php Outdated
Comment thread lib/private/Avatar/RemoteAvatar.php Outdated
Comment thread lib/private/Avatar/RemoteAvatar.php Outdated
Comment thread lib/private/Avatar/RemoteAvatar.php
Comment thread lib/private/Avatar/RemoteAvatar.php Outdated
Comment thread lib/private/Avatar/RemoteAvatar.php Outdated
Comment thread tests/lib/Avatar/RemoteAvatarTest.php Outdated

@CarlSchwan CarlSchwan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix it and merge it :)

Comment thread lib/private/Avatar/AvatarManager.php
Comment thread lib/private/Avatar/RemoteAvatar.php Outdated
Comment thread lib/private/Avatar/RemoteAvatar.php
Comment thread lib/private/Avatar/AvatarManager.php Outdated
@leftybournes
leftybournes force-pushed the leftybournes/feat/federatedshares-show-avatars branch from c978147 to f2cd0a8 Compare August 4, 2026 10:49
@leftybournes
leftybournes enabled auto-merge August 4, 2026 10:52
Signed-off-by: Kent Delante <kent@delante.me>
Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: Kent Delante <kent@delante.me>
Assisted-by: ClaudeCode:claude-sonnet-5
@leftybournes
leftybournes force-pushed the leftybournes/feat/federatedshares-show-avatars branch from f2cd0a8 to b562f28 Compare August 5, 2026 07:40
@leftybournes
leftybournes disabled auto-merge August 6, 2026 10:53
@sorbaugh
sorbaugh merged commit 0ce518e into master Aug 6, 2026
209 of 215 checks passed
@sorbaugh
sorbaugh deleted the leftybournes/feat/federatedshares-show-avatars branch August 6, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants