fix(core): report full relative paths in integrity checker for apps - #62332
fix(core): report full relative paths in integrity checker for apps#62332gitedmond wants to merge 2 commits into
Conversation
Prepend the relative app folder and app ID to reported filenames when verifying app signatures. This ensures the output reports the full, correct path (e.g. apps/twofactor_totp/js/... instead of js/...). Assisted-by: Antigravity:Gemini-3.5-Flash Signed-off-by: Edmond <edmnd@users.noreply.github.com>
e75b64d to
2fdbc65
Compare
…allback Assisted-by: Antigravity:Gemini-3.5-Flash Signed-off-by: Edmond <edmnd@users.noreply.github.com>
a16c2da to
a2f1caf
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Prepend the relative app folder and app ID to reported filenames when verifying app signatures to report full relative paths in the integrity checker.
Assisted-by: Antigravity:Gemini-3.5-Flash
Summary
Prepend the relative app folder and app ID to reported filenames when verifying app signatures. This ensures the integrity check list output reports the full, correct path (e.g.
apps/twofactor_totp/js/...instead ofjs/...) for missing or modified app-specific files.Right now, if an app file fails verification, the integrity scanner only reports the path inside the app folder itself (like
js/...instead ofapps/twofactor_totp/js/...). This pr just prepends the app's relative directory to the path so you actually know where to look when files go missing.Changes
verify()insidelib/private/IntegrityCheck/Checker.phpto prefix reported app filenames with their relative directory path resolved via theEnvironmentHelper(or standardapps/layout).tests/lib/IntegrityCheck/CheckerTest.phptests to align with the new prefixed path format.Checklist
git commit --amend -son the branch to add your DCO signature)3. to review, feature component)stable32)AI (if applicable)