Skip to content

fix(core): report full relative paths in integrity checker for apps - #62332

Open
gitedmond wants to merge 2 commits into
nextcloud:masterfrom
gitedmond:fix/integrity-path-prefix
Open

fix(core): report full relative paths in integrity checker for apps#62332
gitedmond wants to merge 2 commits into
nextcloud:masterfrom
gitedmond:fix/integrity-path-prefix

Conversation

@gitedmond

@gitedmond gitedmond commented Jul 19, 2026

Copy link
Copy Markdown

Prepend the relative app folder and app ID to reported filenames when verifying app signatures to report full relative paths in the integrity checker.

Assisted-by: Antigravity:Gemini-3.5-Flash

Summary

Prepend the relative app folder and app ID to reported filenames when verifying app signatures. This ensures the integrity check list output reports the full, correct path (e.g. apps/twofactor_totp/js/... instead of js/...) for missing or modified app-specific files.

Right now, if an app file fails verification, the integrity scanner only reports the path inside the app folder itself (like js/... instead of apps/twofactor_totp/js/...). This pr just prepends the app's relative directory to the path so you actually know where to look when files go missing.

Changes

  • Updated the differences scanner loop in verify() inside lib/private/IntegrityCheck/Checker.php to prefix reported app filenames with their relative directory path resolved via the EnvironmentHelper (or standard apps/ layout).
  • Configured environment helper mocks and updated expected paths inside tests/lib/IntegrityCheck/CheckerTest.php tests to align with the new prefixed path format.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits (Note: You must run git commit --amend -s on the branch to add your DCO signature)
  • Tests (unit, integration, api and/or acceptance) are included
  • Screenshots before/after for front-end changes
  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable (ex: critical bugfixes)
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Prepend the relative app folder and app ID to reported filenames when verifying app signatures. This ensures the output reports the full, correct path (e.g. apps/twofactor_totp/js/... instead of js/...).

Assisted-by: Antigravity:Gemini-3.5-Flash
Signed-off-by: Edmond <edmnd@users.noreply.github.com>
@gitedmond
gitedmond force-pushed the fix/integrity-path-prefix branch from e75b64d to 2fdbc65 Compare July 19, 2026 18:38
@gitedmond
gitedmond marked this pull request as ready for review July 19, 2026 18:49
@gitedmond
gitedmond requested a review from a team as a code owner July 19, 2026 18:49
@gitedmond
gitedmond requested review from Altahrim, icewind1991, leftybournes and salmart-dev and removed request for a team July 19, 2026 18:49
…allback

Assisted-by: Antigravity:Gemini-3.5-Flash
Signed-off-by: Edmond <edmnd@users.noreply.github.com>
@gitedmond
gitedmond force-pushed the fix/integrity-path-prefix branch from a16c2da to a2f1caf Compare July 20, 2026 14:20
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: List of missing files does not always show correct file path

2 participants