test(TestCase): restore unregistered services correctly - #62326
Merged
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
3. to review
joshtrichards
requested review from
Altahrim,
come-nc,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
July 19, 2026 14:37
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
CarlSchwan
approved these changes
Jul 20, 2026
come-nc
approved these changes
Aug 3, 2026
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
Test\TestCase::restoreService()to remove a temporary DI-container registration when the service did not exist beforeoverwriteService()was called.Previously, restoration attempted to unset the saved service value (
false) instead of the service name, leaving the test override registered and potentially leaking it into subsequent tests.Related/introduced in #53523
Possible follow-up: May be worth adding test coverage for more for of our test infrastructure; particularly this base class. Leaving out of scope since that deserves its own PR.
Checklist
3. to review, feature component)stable32)AI (if applicable)