feat(recent-files): add recent_files_limit config on files settings#58761
Draft
cristianscheid wants to merge 1 commit intomasterfrom
Draft
feat(recent-files): add recent_files_limit config on files settings#58761cristianscheid wants to merge 1 commit intomasterfrom
cristianscheid wants to merge 1 commit intomasterfrom
Conversation
7 tasks
7a4ad31 to
7631ec7
Compare
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
7631ec7 to
da37572
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recent_files_limitoption to the Files settings menu, persisted in theoc_preferencestable.getRecentSearchCustom()method from the library counterpart atnextcloud-libraries/nextcloud-files.nextcloud-libraries/nextcloud-filesPR being merged first to support thelimitparameter: feat(recent-search): add parameter to allow dynamic limit of returned… nextcloud-libraries/nextcloud-files#1527Visuals
Screencast.from.06-03-2026.18.53.02.webm
TODO
<d:getlastmodified/>.lib/private/Files/Node/Folder::search()receives the order by parameter and does the sorting callinglib/private/Files/Search/SearchOrder::sortFileInfoNoDirection(), which does not take into consideration upload time, leaving recently uploaded files that have older modification dates at the bottom, and depending on the limit set, out of the list.Open Questions
<nc:last_activity>DAV attribute that resolves tomax(uploadTime, mtime), ensuring that recently uploaded files with an older mtime have their upload_time considered instead, giving a more accurate recencly ordering?<nc:upload_time/>and the frontend could request to order by it, resolving asmax(uploadTime, mtime)internally when sorting, avoiding a new attribute altogether:Checklist
3. to review, feature component)stable32)AI (if applicable)