[stable32] fix(share): Set expiration time to end of day (23:59:59)#58709
Open
backportbot[bot] wants to merge 2 commits intostable32from
Open
[stable32] fix(share): Set expiration time to end of day (23:59:59)#58709backportbot[bot] wants to merge 2 commits intostable32from
backportbot[bot] wants to merge 2 commits intostable32from
Conversation
Shares now expire at the end of the selected day instead of the beginning, allowing access throughout the entire expiration day. Also return actual stored time in API response instead of hardcoded 00:00:00 to prevent timezone-related display issues in the UI. Signed-off-by: nfebe <fenn25.fn@gmail.com>
jancborchardt
approved these changes
Mar 4, 2026
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Approving functionality design-wise, but not tested
Update expected values in ManagerTest to reflect the new behavior where share expiration dates are set to 23:59:59 instead of 00:00:00. Signed-off-by: nfebe <fenn25.fn@gmail.com> Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
backport/58128/stable32
branch
from
c5a44df to
0535b10
Compare
CarlSchwan
requested review from
ArtificialOwl,
come-nc and
salmart-dev
and removed request for
a team
CarlSchwan
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58128
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.