chore: cleanup some unused capability/sharing methods#10348
Open
nilsding wants to merge 3 commits into
Open
Conversation
Member
Author
|
/backport to stable-34.0 please |
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
We use `label` for that Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
nilsding
force-pushed
the
refactor/noid/remove-unused-sharing-methods
branch
from
29128ac to
b7817be
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10348.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
mgallien
requested changes
Jul 10, 2026
mgallien
left a comment
mgallien
left a comment
Collaborator
There was a problem hiding this comment.
please see my question
| continue; | ||
|
|
||
| if (linkShare->getName() == shareName) { | ||
| if (linkShare->getLabel() == shareName) { |
Collaborator
There was a problem hiding this comment.
should we not also rename shareName to shareLabel ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted from #10307, each removal is in a separate commit
Checklist
AI (if applicable)