Skip to content

feat: Add the possibility to create invitation links to circles - #2254

Merged
Koc merged 3 commits into
masterfrom
feature/invitation-links-to-circles
Aug 7, 2026
Merged

feat: Add the possibility to create invitation links to circles#2254
Koc merged 3 commits into
masterfrom
feature/invitation-links-to-circles

Conversation

@Koc

@Koc Koc commented Nov 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds possibility to generate invitation link (even for completely hidden/closed Circles). Any user is able to join to the circle by opening this link.

🖼️ Screenshots

image image image

Dependencies

@Koc Koc mentioned this pull request Nov 29, 2025
Open
@Koc
Koc force-pushed the feature/invitation-links-to-circles branch 13 times, most recently from 8301408 to a89bf72 Compare November 30, 2025 22:40
@Koc
Koc force-pushed the feature/invitation-links-to-circles branch 3 times, most recently from baffcc3 to af15456 Compare December 7, 2025 13:19
@Koc
Koc marked this pull request as ready for review December 7, 2025 13:26
@Koc
Koc requested a review from ArtificialOwl December 7, 2025 13:27
@Koc
Koc force-pushed the feature/invitation-links-to-circles branch from af15456 to 018eea9 Compare April 16, 2026 09:12
@Koc
Koc force-pushed the feature/invitation-links-to-circles branch from 018eea9 to 08b6110 Compare May 4, 2026 14:09
@Koc
Koc force-pushed the feature/invitation-links-to-circles branch 2 times, most recently from 213cfc1 to b01cd7a Compare June 9, 2026 19:16
artonge
artonge reviewed Jun 10, 2026
View reviewed changes
Comment thread lib/Model/CircleInvitation.php Outdated
Comment thread lib/FederatedItems/CircleCreateInvitation.php
$initiatorHelper = new MemberHelper($circle->getInitiator());
$initiatorHelper->mustBeAdmin();

$new = clone $circle;

@artonge artonge May 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it needed to clone the circle object?

@Koc Koc Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just inspired from already existent verify method implementations:

Comment thread lib/Db/CircleInvitationRequest.php
*
* @throws InvalidIdException
*/
public function replace(CircleInvitation $circleInvitation): void {

@artonge artonge Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could there be multiple invitation per circle? If so, shouldn't we delete a specific invitation, and not all of them?

@Koc Koc Jun 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not now. In theory we can add that, but in this case we need rework UI and introduce something like "invitation link name" to distinguish links.

I would like to start with something really simple and improve it later

Comment thread lib/Db/CircleInvitationRequest.php Outdated
Comment thread lib/Db/CircleRequest.php
Comment thread lib/Db/CircleRequestBuilder.php Outdated
Comment thread lib/Service/CircleService.php Outdated
@Koc
Koc force-pushed the feature/invitation-links-to-circles branch 2 times, most recently from bac0d4e to 524ff22 Compare June 28, 2026 10:56
@Koc
Koc requested a review from mejo- June 28, 2026 11:08
@Koc
Koc force-pushed the feature/invitation-links-to-circles branch from 524ff22 to 63d11c0 Compare June 28, 2026 11:16
@Koc
Koc force-pushed the feature/invitation-links-to-circles branch 3 times, most recently from c1227d7 to ab2ab91 Compare June 28, 2026 12:49
cristianscheid
cristianscheid reviewed Jul 7, 2026
View reviewed changes
Comment thread lib/FederatedItems/CircleJoin.php
Comment thread lib/Controller/LocalController.php
Comment thread lib/Controller/LocalController.php
@Koc
Koc force-pushed the feature/invitation-links-to-circles branch from ab2ab91 to 644c2ea Compare July 25, 2026 15:37
@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Koc
Koc force-pushed the feature/invitation-links-to-circles branch 4 times, most recently from 5d77d17 to d8e7f2a Compare July 26, 2026 15:34
@Koc

Koc commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

@artonge @cristianscheid mates, I've resolved/responded to all of your comments. Also this PR contains FE part as well (as we've moving UI for teams management to the Circles module). Please check one more time.

Also I have no idea how to build js to pass corresponding pipeline step, please help here (npm ci && npm run build not helps)

@Koc
Koc force-pushed the feature/invitation-links-to-circles branch 5 times, most recently from 2936a42 to ea4ec9f Compare July 27, 2026 18:13
@Koc
Koc requested review from artonge and cristianscheid July 28, 2026 22:02
@Koc

Koc commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/compile

miaulalala
miaulalala approved these changes Jul 30, 2026
View reviewed changes

@miaulalala miaulalala left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some tests would be welcome but not a blocker for me

@Koc

Koc commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

@miaulalala thanx, Anna!

I thought about tests, but:

  • Unit tests has no sense here
  • Functional tests (Behat) are not bootstrapped in this project at all
  • E2e (Cypress/Playwright) tests looks a bit expensive

I'm completely fine to return to that topic and cover new endpoints with Behat tests once we have initial infrastructure for that (like in other modules like Forms/Tables/etc)

@AIlkiv
AIlkiv self-requested a review July 31, 2026 13:37
AIlkiv
AIlkiv approved these changes Jul 31, 2026
View reviewed changes

@AIlkiv AIlkiv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a review — it looks very good.

Koc added 2 commits August 7, 2026 15:02
@Koc
feat: Add the possibility to create invitation links to circles
38050c3 
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc
feat: Add the possibility to create invitation links to circles (FE)
e779a6b 
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc
Koc force-pushed the feature/invitation-links-to-circles branch from 935122b to e779a6b Compare August 7, 2026 13:03
@Koc

Koc commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/compile

@nextcloud-command
chore(assets): Recompile assets
9c0a497 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Koc
Koc merged commit 5ae40eb into master Aug 7, 2026
44 of 45 checks passed
@Koc
Koc deleted the feature/invitation-links-to-circles branch August 7, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AIlkiv AIlkiv AIlkiv approved these changes
@miaulalala miaulalala miaulalala approved these changes
@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner
@mejo- mejo- Awaiting requested review from mejo-
@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner
@artonge artonge Awaiting requested review from artonge
@cristianscheid cristianscheid Awaiting requested review from cristianscheid

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Koc @AIlkiv @artonge @miaulalala @cristianscheid @nextcloud-command