fix: eslint config and apply changes

eslint.config.js

@@ -0,0 +1,10 @@
+/**
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+import { recommendedJavascript } from '@nextcloud/eslint-config'
+
+export default [
+	...recommendedJavascript,
+]

package.json

@@ -23,8 +23,8 @@
     "test": "vitest run",
     "test:coverage": "vitest run --coverage",
     "test:watch": "vitest",
-    "lint": "eslint --ext .js src",
-    "lint:fix": "eslint --ext .js src --fix"
+    "lint": "eslint src",
+    "lint:fix": "eslint src --fix"
   },
   "repository": {
     "type": "git",

src/debug.js

@@ -9,8 +9,9 @@
 
 /**
  * creates a debug function bound to a context
+ *
  * @param {string} context
  * @return {Function}
  */
 export function debugFactory(context) {
 	return (...args) => {

src/errors/attachError.js

@@ -13,15 +13,13 @@
  * @abstract
  */
 export default class AttachError extends Error {
-
 	/**
 	 *
 	 * @param {object} attach
 	 */
 	constructor(attach) {
 		super()
 
 		Object.assign(this, attach)
 	}
-
 }

src/index.js

@@ -1,3 +1,7 @@
+import { debugFactory } from './debug.js'
+import { AddressBookHome } from './models/addressBookHome.js'
+import { CalendarHome } from './models/calendarHome.js'
+import { Principal } from './models/principal.js'
 /**
  * CDAV Library
  *
@@ -10,11 +14,6 @@
 import Request from './request.js'
 import * as NS from './utility/namespaceUtility.js'
 import * as XMLUtility from './utility/xmlUtility.js'
-import { CalendarHome } from './models/calendarHome.js'
-import { AddressBookHome } from './models/addressBookHome.js'
-import { Principal } from './models/principal.js'
-
-import { debugFactory } from './debug.js'
 const debug = debugFactory('index.js')
 
 export { debugFactory as debug, NS as namespaces }
@@ -23,13 +22,13 @@
  *
  */
 export default class DavClient {
-
 	/**
 	 * @param {object} options
 	 * @param {string} options.rootUrl
 	 * @param {{[name: string]: any}} [options.defaultHeaders] A dictionary of default headers to apply to each request.
 	 * @param {object} factories
 	 */
+	// eslint-disable-next-line no-unused-vars
 	constructor(options, factories = {}) {
 		/**
 		 * root URL of DAV Server
@@ -111,7 +110,8 @@
 
 	/**
 	 * initializes the DAVClient
+	 *
 	 * @param {object} options
 	 * @return {Promise<DavClient>}
 	 */
 	async connect(options = { enableCalDAV: false, enableCardDAV: false }) {
@@ -176,7 +176,7 @@
 	/**
 	 * performs a principal property search based on a principal's displayname
 	 *
 	 * @param {string} name
 	 * @return {Promise<Principal[]>}
 	 */
 	async principalPropertySearchByDisplayname(name) {
@@ -188,7 +188,7 @@
 	/**
 	 * performs a principal property search based on a principal's displayname OR email address
 	 *
 	 * @param {string} value
 	 * @return {Promise<Principal[]>}
 	 */
 	async principalPropertySearchByDisplaynameOrEmail(value) {
@@ -218,8 +218,7 @@
 	 * @return {Promise<[]>}
 	 */
 	async principalPropertySearchByAddressAndStory(address, story) {
-		const [skeleton] = XMLUtility.getRootSkeleton(
-			[NS.DAV, 'principal-property-search'])
+		const [skeleton] = XMLUtility.getRootSkeleton([NS.DAV, 'principal-property-search'])
 
 		skeleton.children.push({
 			name: [NS.DAV, 'property-search'],
@@ -372,6 +371,7 @@
 
 	/**
 	 * performs a principal property search
+	 *
 	 * @see https://tools.ietf.org/html/rfc3744#section-9.4
 	 *
 	 * @param {Array} props
@@ -432,6 +432,7 @@
 			return new Principal(null, this._request, principalUrl, body)
 		}).catch((err) => {
 			// TODO: improve error handling
+			// eslint-disable-next-line no-console
 			console.debug(err)
 		})
 	}
@@ -461,6 +462,7 @@
 			return principals
 		} catch (err) {
 			// TODO: improve error handling
+			// eslint-disable-next-line no-console
 			console.debug(err)
 		}
 	}
@@ -519,6 +521,7 @@
 
 	/**
 	 * Fetches the group-member-set of a principal collection (e.g. a calendar-proxy group).
+	 *
 	 * @see https://tools.ietf.org/html/rfc3744#section-4.3
 	 *
 	 * @param {string} groupUrl Absolute URL of the proxy group principal
@@ -534,6 +537,7 @@
 
 	/**
 	 * Sets the group-member-set of a principal collection (e.g. a calendar-proxy group).
+	 *
 	 * @see https://tools.ietf.org/html/rfc3744#section-4.3
 	 *
 	 * @param {string} groupUrl Absolute URL of the proxy group principal
@@ -561,6 +565,7 @@
 
 	/**
 	 * Fetches the group-membership of a principal (the groups it belongs to).
+	 *
 	 * @see https://tools.ietf.org/html/rfc3744#section-4.4
 	 *
 	 * @param {string} principalUrl Absolute URL of the principal
@@ -636,7 +641,7 @@
 	 *
 	 * @param {string} ownerPrincipalUrl Absolute URL of the principal who owns the proxy group
 	 * @param {string} delegatePrincipalUrl Absolute or relative URL of the principal to add as delegate
-	 * @param {'write'|'read'} [permission='write'] The proxy group to add the delegate to
+	 * @param {'write'|'read'} [permission] The proxy group to add the delegate to
 	 * @return {Promise<void>}
 	 */
 	async addDelegate(ownerPrincipalUrl, delegatePrincipalUrl, permission = 'write') {
@@ -653,7 +658,7 @@
 	 *
 	 * @param {string} ownerPrincipalUrl Absolute URL of the principal who owns the proxy group
 	 * @param {string} delegatePrincipalUrl Absolute or relative URL of the principal to remove
-	 * @param {'write'|'read'} [permission='write'] The proxy group to remove the delegate from
+	 * @param {'write'|'read'} [permission] The proxy group to remove the delegate from
 	 * @return {Promise<void>}
 	 */
 	async removeDelegate(ownerPrincipalUrl, delegatePrincipalUrl, permission = 'write') {
@@ -797,5 +802,4 @@
 		const url = this._request.pathname(this.rootUrl) + 'public-calendars/'
 		this.publicCalendarHome = new CalendarHome(this, this._request, url, {})
 	}
-
 }

src/models/addressBook.js

@@ -7,15 +7,14 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-import { davCollectionShareable } from './davCollectionShareable.js'
-import { DavCollection } from './davCollection.js'
+import { debugFactory } from '../debug.js'
+import addressBookPropSet from '../propset/addressBookPropSet.js'
 import * as NS from '../utility/namespaceUtility.js'
 import * as StringUtility from '../utility/stringUtility.js'
 import * as XMLUtility from '../utility/xmlUtility.js'
-import addressBookPropSet from '../propset/addressBookPropSet.js'
+import { DavCollection } from './davCollection.js'
+import { davCollectionShareable } from './davCollectionShareable.js'
 import { VCard } from './vcard.js'
-
-import { debugFactory } from '../debug.js'
 const debug = debugFactory('AddressBook')
 
 /**
@@ -33,7 +32,6 @@ const debug = debugFactory('AddressBook')
  * @augments DavCollection
  */
 export class AddressBook extends davCollectionShareable(DavCollection) {
-
 	/**
 	 * @inheritDoc
 	 */
@@ -121,9 +119,7 @@ export class AddressBook extends davCollectionShareable(DavCollection) {
 	async addressbookQuery(filter, prop = null, limit = null, test = 'anyof') {
 		debug('sending an addressbook-query request')
 
-		const [skeleton] = XMLUtility.getRootSkeleton(
-			[NS.IETF_CARDDAV, 'addressbook-query'],
-		)
+		const [skeleton] = XMLUtility.getRootSkeleton([NS.IETF_CARDDAV, 'addressbook-query'])
 
 		if (!prop) {
 			skeleton.children.push({
@@ -221,9 +217,7 @@ export class AddressBook extends davCollectionShareable(DavCollection) {
 	 * @private
 	 */
 	_buildMultiGetBody(hrefs, prop) {
-		const [skeleton] = XMLUtility.getRootSkeleton(
-			[NS.IETF_CARDDAV, 'addressbook-multiget'],
-		)
+		const [skeleton] = XMLUtility.getRootSkeleton([NS.IETF_CARDDAV, 'addressbook-multiget'])
 
 		if (!prop) {
 			skeleton.children.push({
@@ -283,5 +277,4 @@ export class AddressBook extends davCollectionShareable(DavCollection) {
 
 		return !!addressBookDataProperty.children
 	}
-
 }

src/models/addressBookHome.js

@@ -7,11 +7,10 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-import { DavCollection } from './davCollection.js'
+import { debugFactory } from '../debug.js'
 import * as NS from '../utility/namespaceUtility.js'
 import { AddressBook } from './addressBook.js'
-
-import { debugFactory } from '../debug.js'
+import { DavCollection } from './davCollection.js'
 const debug = debugFactory('AddressBookHome')
 
 /**
@@ -23,7 +22,6 @@ const debug = debugFactory('AddressBookHome')
  * a server to return multiple address book homes though.
  */
 export class AddressBookHome extends DavCollection {
-
 	/**
 	 * @inheritDoc
 	 */
@@ -66,5 +64,4 @@ export class AddressBookHome extends DavCollection {
 		const name = super._getAvailableNameFromToken(displayname)
 		return super.createCollection(name, props)
 	}
-
 }

src/models/calendar.js

@@ -7,16 +7,15 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-import { DavCollection } from './davCollection.js'
-import { davCollectionPublishable } from './davCollectionPublishable.js'
-import { davCollectionShareable } from './davCollectionShareable.js'
-import { VObject } from './vobject.js'
+import { debugFactory } from '../debug.js'
 import calendarPropSet from '../propset/calendarPropSet.js'
 import * as NS from '../utility/namespaceUtility.js'
 import * as StringUtility from '../utility/stringUtility.js'
 import * as XMLUtility from '../utility/xmlUtility.js'
-
-import { debugFactory } from '../debug.js'
+import { DavCollection } from './davCollection.js'
+import { davCollectionPublishable } from './davCollectionPublishable.js'
+import { davCollectionShareable } from './davCollectionShareable.js'
+import { VObject } from './vobject.js'
 const debug = debugFactory('Calendar')
 
 /**
@@ -40,7 +39,6 @@ const debug = debugFactory('Calendar')
  * @augments DavCollection
  */
 export class Calendar extends davCollectionPublishable(davCollectionShareable(DavCollection)) {
-
 	/**
 	 * @inheritDoc
 	 */
@@ -147,9 +145,7 @@ export class Calendar extends davCollectionPublishable(davCollectionShareable(Da
 	async calendarQuery(filter, prop = null, timezone = null) {
 		debug('sending an calendar-query request')
 
-		const [skeleton] = XMLUtility.getRootSkeleton(
-			[NS.IETF_CALDAV, 'calendar-query'],
-		)
+		const [skeleton] = XMLUtility.getRootSkeleton([NS.IETF_CALDAV, 'calendar-query'])
 
 		if (!prop) {
 			skeleton.children.push({
@@ -203,9 +199,7 @@ export class Calendar extends davCollectionPublishable(davCollectionShareable(Da
 			return []
 		}
 
-		const [skeleton] = XMLUtility.getRootSkeleton(
-			[NS.IETF_CALDAV, 'calendar-multiget'],
-		)
+		const [skeleton] = XMLUtility.getRootSkeleton([NS.IETF_CALDAV, 'calendar-multiget'])
 
 		if (!prop) {
 			skeleton.children.push({
@@ -242,24 +236,24 @@ export class Calendar extends davCollectionPublishable(davCollectionShareable(Da
 	 * @param {Date} to
 	 * @return {Promise<string>}
 	 */
+	// eslint-disable-next-line no-unused-vars
 	async freeBusyQuery(from, to) {
-		/* eslint-disable no-tabs */
+
 		// debug('sending a free-busy-query request');
 		//
 		// const [skeleton] = XMLUtility.getRootSkeleton(
-		// 	[NS.IETF_CALDAV, 'free-busy-query'],
-		// 	[NS.IETF_CALDAV, 'time-range']
+		//     [NS.IETF_CALDAV, 'free-busy-query'],
+		//     [NS.IETF_CALDAV, 'time-range']
 		// );
 		//
 		// skeleton[0][0].attributes.push(['start', Calendar._getICalendarDateTimeFromDateObject(from)]);
 		// skeleton[0][0].attributes.push(['end', Calendar._getICalendarDateTimeFromDateObject(to)]);
 		//
 		// const headers = {
-		// 	'Depth': '1'
+		//     'Depth': '1'
 		// };
 		// const body = XMLUtility.serialize(skeleton);
 		// const response = await this._request.report(this.url, headers, body);
-		/* eslint-enable no-tabs */
 
 		// TODO - finish implementation
 	}
@@ -336,5 +330,4 @@ export class Calendar extends davCollectionPublishable(davCollectionShareable(Da
 			'Z',
 		].join('')
 	}
-
 }