feat: configurable allowed orgs#835
Open
vitormattos wants to merge 2 commits intonextcloud:masterfrom
Open
Conversation
Add regression coverage for the default org allowlist and for overriding it through the ALLOWED_ORGS environment variable. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
The current allowlist is hardcoded in the application, which makes reuse across different GitHub App installations depend on patching the source. Read the allowlist from the ALLOWED_ORGS environment variable and keep the existing defaults when it is unset or empty. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the allowed organization list configurable through the
ALLOWED_ORGSenvironment variable while preserving the current defaults when the variable is unset or empty.Today the allowlist is hardcoded in the application, which makes reuse in other GitHub App installations require source changes. With this adjustment, deployments can configure the allowed organizations externally without changing existing behavior for current setups.
Tests were added to cover both the default fallback and the environment-based configuration.