Skip to content

fix: ExApp upgrade 401 on set_init_status#807

Merged
oleksandr-nc merged 1 commit intomainfrom
fix/init-status-401-on-upgrade
Mar 2, 2026
Merged

fix: ExApp upgrade 401 on set_init_status#807
oleksandr-nc merged 1 commit intomainfrom
fix/init-status-401-on-upgrade

Conversation

@oleksandr-nc
Copy link
Contributor

@oleksandr-nc oleksandr-nc commented Mar 2, 2026

Related github issue: #803

Changes proposed in this PR:

  • Check enableExAppInternal() return value in dispatchExAppInitInternal and abort if it fails
  • Allow disabled ExApps to access /ex-app/status during install/update (protected on server-side with help of status.type)
  • Add PHPUnit tests for both fixes
  • Add PHPUnit CI workflow

@oleksandr-nc oleksandr-nc requested a review from kyteinsky March 2, 2026 07:31
oleksandr-nc added a commit to cloud-py-api/nc_py_api that referenced this pull request Mar 2, 2026
Fix for some flaky situations where ExApp can fail to update it's status
during install/update in AppAPI will be only for the new endpoint:

nextcloud/app_api#807

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Changed**
* App initialization status reporting now uses a new standardized
endpoint for reporting progress and errors.

* **Chores**
  * Package version updated to 0.24.2.dev0.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
Copy link
Collaborator

@kyteinsky kyteinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few nits but nothing required to be changed

Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
@oleksandr-nc oleksandr-nc force-pushed the fix/init-status-401-on-upgrade branch from 33e3743 to 920974a Compare March 2, 2026 13:27
@oleksandr-nc oleksandr-nc enabled auto-merge March 2, 2026 13:28
@oleksandr-nc oleksandr-nc merged commit 604f73c into main Mar 2, 2026
40 checks passed
@oleksandr-nc oleksandr-nc deleted the fix/init-status-401-on-upgrade branch March 2, 2026 13:41
oleksandr-nc added a commit that referenced this pull request Mar 2, 2026
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants