fix(accessibility): fix some accessibility issues#2450
fix(accessibility): fix some accessibility issues#2450miaulalala wants to merge 1 commit intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
/compile amend / |
nextcloud-command
force-pushed
the
fix/noid/accessibility-issues
branch
from
35e6401 to
1e69519
Compare
Activity
|
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
fix/noid/accessibility-issues
|
| Run status |
|
| Run duration | 02m 06s |
| Commit |
|
| Committer | Anna |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
9
|
| View all changes introduced in this branch ↗︎ | |
miaulalala
force-pushed
the
fix/noid/accessibility-issues
branch
from
1e69519 to
b52ef20
Compare
|
/compile amend |
Signed-off-by: Anna Larch <anna@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/noid/accessibility-issues
branch
from
b52ef20 to
5646c95
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 27 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| v-if="isRoot" | ||
| :title="t('activity', 'Home')" | ||
| aria-label="t('activity', 'Home')" | ||
| :aria-label="t('activity', 'Home')" |
There was a problem hiding this comment.
The root-folder icon is rendered as an empty with an icon class. Relying on aria-label on a generic span is not reliably announced by screen readers because the element has no semantic role/content. To ensure the icon has an accessible name, consider adding an explicit role="img" (or alternatively render a visually-hidden text node and mark the icon aria-hidden="true").
| :aria-label="t('activity', 'Home')" | |
| :aria-label="t('activity', 'Home')" | |
| role="img" |
No description provided.