Skip to content

fix: revert ESLint to v9 to fix linter#901

Merged
susnux merged 1 commit intomainfrom
fix/linting
Mar 3, 2026
Merged

fix: revert ESLint to v9 to fix linter#901
susnux merged 1 commit intomainfrom
fix/linting

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Mar 3, 2026

No description provided.

@susnux susnux requested a review from ShGKme March 3, 2026 11:19
@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.71%. Comparing base (49a8ff1) to head (6d386a2).
⚠️ Report is 86 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #901   +/-   ##
=======================================
  Coverage   60.71%   60.71%           
=======================================
  Files           4        4           
  Lines          56       56           
  Branches       17       17           
=======================================
  Hits           34       34           
  Misses         20       20           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we ever allow dependabot to make major updates on its own...

@susnux
Copy link
Contributor Author

susnux commented Mar 3, 2026

Why do we ever allow dependabot to make major updates on its own...

Otherwise in most cases they would never be done.
But they should not be auto-merged.

(and in this case the CI was not required)

@susnux susnux merged commit 2ea86ef into main Mar 3, 2026
9 checks passed
@susnux susnux deleted the fix/linting branch March 3, 2026 12:39
@ShGKme
Copy link
Contributor

ShGKme commented Mar 3, 2026

Otherwise in most cases they would never be done.

We can create a PR, and then the app/lib maintainers should take care of the open PRs. But silent merge is likely to cause issues even with green CI in a case of behavior change.

@susnux
Copy link
Contributor Author

susnux commented Mar 3, 2026

yes thats what I meant with But they should not be auto-merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants