Repository navigation
fix: data-folder lock, readable socket errors, Monitor warm-up, chip wrap, local version - #17
Merged
Conversation
…wrap, local version Failure classes found while shooting the docs, each fixed where every instance of it goes through: - Unix socket paths over the 103-byte sun_path limit: one helper (UnixSocketPath) now checks every socket DockZ binds or connects to. A docker.sock that can't be created is shown in the dashboard instead of only logged, and moving the data folder refuses such a location up front. - One data folder, two owners: an flock on <root>/.dockz.lock lets one DockZ process own a data folder (Docker VM and machines alike); a second copy explains who holds it and quits. A VM that never reached .running is reported, not restarted; one that crashes while running still is. - Monitor warm-up: the disk breakdown is requested every tick until the first one arrives (one request at a time), and the table says it is reading stats rather than "No running containers". - List headers: scope chips never wrap; the search field gives up width. Shared by all eight list pages. - Local builds take CFBundleShortVersionString / CFBundleVersion from the latest v* tag and the commit count instead of a hardcoded 0.1.0. Tests: 16 new checks (260 total, all passing) for the socket limit, the lock, stop classification and breakdown sampling; the lock was also checked across processes (holder named, released on exit, stale file ignored). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Deploying dockz with
|
| Latest commit: |
610720c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://75b9678b.dockz.pages.dev |
| Branch Preview URL: | https://fix-robustness-socket-lock-m.dockz.pages.dev |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five failure classes found while shooting the docs. Each is fixed at the shared layer every instance goes through, not at the one spot where it showed up.
sun_pathlimit fails silentlyUnixSocketPathhelper used by every bind/connect. A faileddocker.socknow shows in the dashboard andhost.loginstead of onlyNSLog.StorageLocation.migraterefuses a too-deep destination before moving anythingdocker.sock,debug-shell.sock, socket environments, moving the data folderflockon<root>/.dockz.lock(released by the kernel on exit/crash). A second copy explains who holds it and quitsVMRestartPolicy.classify: never reached.running→ report, don't retry; stopped on its own while running → restart (unchanged)ListHeaderBar)v*tag, build number from the commit count; CI still overridesbuild-and-bundle-app.shTesting
swift run DockzApp test: 260 checks pass, 16 of them new:lsof).scripts/build-and-bundle-app.shstamps0.2.1 (28), matchinggit describeandrev-list --count.Note
The lock only protects once every running copy has it. An already-installed older DockZ doesn't take the lock.
🤖 Generated with Claude Code