Repository navigation
fix(release): build script no longer exits silently without a signing cert - #12
Merged
Merged
Conversation
… cert The v0.2.0 release run failed at "Build app" with only "exit code 1": the script runs under `set -euo pipefail`, and its lookup of an "Apple Development" certificate piped through grep — on a CI runner there is none, grep exits 1, and the script stopped before printing anything. - The lookup runs only when SIGN_IDENTITY is unset and treats "no certificate" as normal (ad-hoc fallback). - build-and-bundle-app.sh and make-dmg.sh trap ERR and print the failing file, line and command, so a script can't fail silently again. Reproduced and verified locally with a stub `security` reporting zero identities: both SIGN_IDENTITY unset and "-" build, sign ad-hoc and pack. v0.2.0 is tagged on the broken commit and release tags are protected, so the release ships as 0.2.1: CHANGELOG moves its notes to 0.2.1 (0.2.0 is marked tagged-not-published); download examples use the 0.2.1 file name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Deploying dockz with
|
| Latest commit: |
190df12
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7a3bf66a.dockz.pages.dev |
| Branch Preview URL: | https://fix-release-build.dockz.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
v0.2.0release run failed at Build app with onlyProcess completed with exit code 1.Cause:
build-and-bundle-app.shruns underset -euo pipefail. Its lookup of an "Apple Development" certificate pipessecurity find-identitythroughgrep; on a GitHub runner there is no certificate,grepexits 1,pipefailpropagates it, andset -eends the script before it prints anything. Locally it never showed because the Mac has such a certificate.Fix (by class — "a lookup allowed to find nothing kills the script silently"):
SIGN_IDENTITYis unset, and "no certificate" is treated as normal (ad-hoc fallback).trap ... ERRand print the failing file, line and command — no more silent exits. No other pipelines in the scripts can fail on "no match".Versioning:
v0.2.0sits on the broken commit and the tag ruleset forbids moving or deleting tags, so this ships as v0.2.1. CHANGELOG moves the full notes to 0.2.1 (0.2.0 marked tagged-not-published); download examples on the site and in the guide use the 0.2.1 file name.Test plan
set -euo pipefail+ a non-matchinggrep.securityreporting 0 identities:SIGN_IDENTITYunset andSIGN_IDENTITY=-both build (exit 0), sign ad-hoc, andmake-dmg.shpacksDockZ-0.2.1.dmg.error: …:<line>: \` failed`.v0.2.1and watch the Release run.🤖 Generated with Claude Code