Skip to content

fix(release): build script no longer exits silently without a signing cert - #12

Merged
tieuanhquoc merged 2 commits into
masterfrom
fix/release-build
Oct 5, 2026
Merged

tieuanhquoc merged 2 commits into
masterfrom
fix/release-build

Conversation

@tieuanhquoc

Copy link
Copy Markdown
Collaborator

Summary

The v0.2.0 release run failed at Build app with only Process completed with exit code 1.

Cause: build-and-bundle-app.sh runs under set -euo pipefail. Its lookup of an "Apple Development" certificate pipes security find-identity through grep; on a GitHub runner there is no certificate, grep exits 1, pipefail propagates it, and set -e ends the script before it prints anything. Locally it never showed because the Mac has such a certificate.

Fix (by class — "a lookup allowed to find nothing kills the script silently"):

  • The lookup runs only when SIGN_IDENTITY is unset, and "no certificate" is treated as normal (ad-hoc fallback).
  • Both build scripts trap ... ERR and print the failing file, line and command — no more silent exits. No other pipelines in the scripts can fail on "no match".

Versioning: v0.2.0 sits on the broken commit and the tag ruleset forbids moving or deleting tags, so this ships as v0.2.1. CHANGELOG moves the full notes to 0.2.1 (0.2.0 marked tagged-not-published); download examples on the site and in the guide use the 0.2.1 file name.

Test plan

  • Reproduced the silent exit with set -euo pipefail + a non-matching grep.
  • Simulated a CI runner with a stub security reporting 0 identities: SIGN_IDENTITY unset and SIGN_IDENTITY=- both build (exit 0), sign ad-hoc, and make-dmg.sh packs DockZ-0.2.1.dmg.
  • ERR trap prints error: …:<line>: \` failed`.
  • 0.2.1 release notes extract from CHANGELOG (16 entries).
  • After merge: tag v0.2.1 and watch the Release run.

🤖 Generated with Claude Code

… cert

The v0.2.0 release run failed at "Build app" with only "exit code 1": the
script runs under `set -euo pipefail`, and its lookup of an "Apple
Development" certificate piped through grep — on a CI runner there is none,
grep exits 1, and the script stopped before printing anything.

- The lookup runs only when SIGN_IDENTITY is unset and treats "no
  certificate" as normal (ad-hoc fallback).
- build-and-bundle-app.sh and make-dmg.sh trap ERR and print the failing
  file, line and command, so a script can't fail silently again.

Reproduced and verified locally with a stub `security` reporting zero
identities: both SIGN_IDENTITY unset and "-" build, sign ad-hoc and pack.

v0.2.0 is tagged on the broken commit and release tags are protected, so
the release ships as 0.2.1: CHANGELOG moves its notes to 0.2.1 (0.2.0 is
marked tagged-not-published); download examples use the 0.2.1 file name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Deploying dockz with  Cloudflare Pages  Cloudflare Pages

Latest commit: 190df12
Status: ✅  Deploy successful!
Preview URL: https://7a3bf66a.dockz.pages.dev
Branch Preview URL: https://fix-release-build.dockz.pages.dev

View logs

@tieuanhquoc
tieuanhquoc merged commit 061cd05 into master Oct 5, 2026
3 checks passed
@tieuanhquoc
tieuanhquoc deleted the fix/release-build branch October 5, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant