chore: Updated app router example to wait for agent to connect and require dotenv in config to load .env for new relic config#376
Merged
Conversation
…quire `dotenv` in config to load `.env` for new relic config
jsumners-nr
approved these changes
Jun 9, 2026
jsumners-nr
left a comment
jsumners-nr
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, but maybe we should wait on started instead?
Comment on lines
+21
to
+24
| if (newrelic.agent.collector.isConnected() === false) { | ||
| await new Promise((resolve) => { | ||
| newrelic.agent.on('connected', resolve) | ||
| }) |
Contributor
There was a problem hiding this comment.
I wonder if this should wait on started:
Member
Author
There was a problem hiding this comment.
connected is enough as we have what we need from collector to provide the browser agent js
github-project-automation
Bot
moved this from Needs PR Review
to Done: Issues recently completed
in Node.js Engineering Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #374 the app was refactored to work with Next 16 and show how to use turbopack. During that refactor, injecting the browser agent broke. This PR resolves that by waiting for the agent to be connected before getting the browser agent header. Also combines
dotnevin config as next.js 16 messes withNODE_OPTIONSand combines duplicate cli args. to--require dotenv/configand--require newrelicwould be--require dotenv/config newrelicwhich no longer works, yay Next.js!