Fix Windows sounds not playing

[zarvox32]

Bug: No sounds play on Windows

Summary

The plugin was completely non-functional on Windows. No sounds were ever heard despite hooks firing correctly.

Root Cause

In hooks/play_sound.py, winsound.PlaySound was called with the SND_ASYNC flag:

winsound.PlaySound(str(sound_file), winsound.SND_FILENAME | winsound.SND_ASYNC)

SND_ASYNC starts sound playback on a background thread and returns immediately. Since the script has nothing left to do after this call, the Python process exits — terminating the background thread and killing the sound before any audio is heard.

This affected all sound events: question, complete, error, and permission.

Fix

Spawn a detached Python process that plays the sound synchronously within itself — the same pattern macOS/Linux already use with start_new_session=True:

if system == "Windows":
    subprocess.Popen(
        [sys.executable, "-c",
         f"import winsound; winsound.PlaySound(r'{sound_file}', winsound.SND_FILENAME)"],
        stdout=subprocess.DEVNULL,
        stderr=subprocess.DEVNULL,
        creationflags=subprocess.DETACHED_PROCESS | subprocess.CREATE_NO_WINDOW,
    )

The parent hook process exits immediately (so the hook timeout is irrelevant), and the detached child plays the sound to completion in the background.

Impact

• Platform: Windows only (macOS and Linux already used detached subprocesses via start_new_session=True)
• Severity: All sounds silently failed — the plugin's entire purpose was broken on Windows
• Status: Fixed

🤖 Generated with Claude Code