Support subscribe/unsubscribe Websocket messages#22
Merged
Conversation
lekkas
force-pushed
the
wss-subscribe-unsubscribe
branch
from
ac0025a to
e402151
Compare
Contributor
Author
|
This PR ended up larger than intended, so I took a more cautious approach
The API is nonbreaking and should work as a drop in replacement in practice. However, to be conservative, I will publish it as a major version change. |
lekkas
changed the title
lekkas
force-pushed
the
wss-subscribe-unsubscribe
branch
from
9dd0310 to
0110bf7
Compare
- Big rewrite, simplified code - Asset groups are no longer supported; a single websocket connection will be created. - Added a lot of new tests
lekkas
force-pushed
the
wss-subscribe-unsubscribe
branch
from
fb81f5d to
a69cd5c
Compare
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20