physics: add NFI CI evidence scoring ledger#1224
Conversation
|
Physics iteration batch summary: Current score: 81.5/100. Status remains |
|
Physics CI evidence iteration status:
Current score remains 81.5 / 100. This PR still does not claim final physics validation, target-rank readiness, or production release readiness. Remaining blockers: full PR Gate evidence, Ricci graph provenance audit, BN-Syn/MFN source refs. |
# Conflicts: # tools/physics_score.py
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05115566a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| release_gate = evidence.get("release_gate", {}) | ||
| return { | ||
| "artifact_present": bool(evidence), | ||
| "physics_runtime_green": required_physics <= successes, |
There was a problem hiding this comment.
Bind CI evidence to the scored commit
When the CI ledger is copied from an earlier PR or branch, this treats matching workflow names as green for whatever checkout is being scored; the new artifact records only PR 1220/1223 refs and no workflow run IDs or head SHA, yet this line can still remove BLOCK-CI-001 and inflate the current score/status. Require the evidence to carry and validate the run SHA against git rev-parse HEAD before setting physics_runtime_green true, otherwise stale CI evidence can promote the physics metrics for unrelated code.
Useful? React with 👍 / 👎.
d334885 to
baeaa65
Compare
Addresses the Codex P2 review: the evidence ledger marked workflows green by NAME only, so CI evidence copied from PR #1220/#1223 (recorded with no head_sha) could strip the physics CI blocker and inflate the score for unrelated code. - physics_ci_evidence.successful_workflows() and physics_score.ci_status() now count a workflow only when its head_sha == the scored commit (git rev-parse HEAD / $GITHUB_SHA); stale/unbound evidence is fail-closed. - validate_evidence emits 'ci_evidence_not_bound_to_scored_commit' / 'head_sha_unresolved' blockers and reports scored_commit_sha. - artifact stamps each workflow_run with the head_sha it executed against (#1220 a6558ea, #1223 3604a60) + binding_note. - tests assert both paths: SHA-bound evidence counts; copied/unresolved is fail-closed. Effect: physics_runtime_green is now honest (S_total 78, not vacuously inflated). claim_status: measured
baeaa65 to
5b6c8b9
Compare
Summary
Adds a machine-readable CI evidence ledger for the NFI physics lane and wires it into the physics scoring oracle.
Current patch batch
Changed files
Score
Validation
Remaining blockers
Non-claims
This PR does not claim final physics validation, target-rank readiness, or production release readiness.