fix: auto-detect PYTHONHOME and catch panics in embedded Python#16
Merged
Conversation
The daemon's embedded Python (pyo3) failed with ModuleNotFoundError for encodings when PYTHONHOME was not set. - Added ensure_pythonhome() that auto-detects prefix from VIRTUAL_ENV or system python3 before any PyO3 initialization. - Wrapped is_available() in catch_unwind so a bad Python init crashes only the embedded probe, not the entire daemon. Fixes #4
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModuleNotFoundError: No module named 'encodings'when PYTHONHOME was not setensure_pythonhome()inembedded.rsthat auto-detects the Python prefix from VIRTUAL_ENV orpython3 -c "import sys; print(sys.base_prefix)"is_available()incatch_unwindso a fatal Python init error crashes only the embedded probe, not the entire daemonTest plan
cargo build --release -p rpytest-daemonrpytest tests/ -q— all tests should pass