Skip to content
This repository was archived by the owner on Jul 7, 2025. It is now read-only.

Refactoring helm chart for provisioning EKS#2

Open
namejsjeongkr wants to merge 1 commit into
netroy:mainfrom
namejsjeongkr:refactoring_helm_chart
Open

Refactoring helm chart for provisioning EKS#2
namejsjeongkr wants to merge 1 commit into
netroy:mainfrom
namejsjeongkr:refactoring_helm_chart

Conversation

@namejsjeongkr

Copy link
Copy Markdown

This PR aims to improve the n8n-eks-cluster project by enhancing its flexibility and adherence to Kubernetes best practices for EKS environments. The main changes include:

  1. Ingress configuration:
  • Added support for both NGINX and ALB Ingress Controllers
  • Implemented dynamic annotation configuration through values.yaml
  1. Secrets management:
  • Moved sensitive database connection information from ConfigMap to Secrets
  • Added annotations to prevent accidental deletion of critical resources
  1. Horizontal Pod Autoscaler (HPA):
  • Implemented flexible HPA configuration for webhook and worker components
  • Added support for custom metrics through values.yaml
  1. Resource management:
  • Introduced configurable resource requests and limits for all components
  • Implemented security contexts for enhanced pod security
  1. Helm best practices:
  • Added standard Kubernetes labels for better resource management
  • Implemented helper templates for consistent labeling across resources

Documentation:

Updated NOTES.txt with deployment information and warnings for default credentials

These changes aim to provide a more robust and customizable n8n deployment on EKS, allowing users to easily adapt the setup to their specific requirements while maintaining security and scalability best practices.

@namejsjeongkr

Copy link
Copy Markdown
Author

@netroy I'd like you to review this one !

@namejsjeongkr namejsjeongkr force-pushed the refactoring_helm_chart branch from a62553b to 6a7d272 Compare April 13, 2025 05:48
@netroy

netroy commented Apr 15, 2025

Copy link
Copy Markdown
Owner

Thanks for doing this.
However, changes like these are very difficult to review because they clump together multiple changes into a single commit, making it harder for a reviewer to make sense of individual change.
I'm going to try to extract these changes bit-by-bit into separate commits into another branch, and will add you as the author.

@namejsjeongkr

Copy link
Copy Markdown
Author

@netroy Do you want me to close this one ?

@netroy

netroy commented Apr 29, 2025

Copy link
Copy Markdown
Owner

no, I'm still working on this. Sorry, it's taking a while.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants