fix(ci): accept a tag input on manual release dispatch - #113
Merged
Conversation
`workflow_dispatch` declared no inputs, so a manual run always reached the
reusable with an empty `tag`. With `create-github-release: true` that is
rejected in "Validate inputs":
create-github-release needs a tag, but the 'tag' input is empty and
this run is on a branch ref ('main').
The dispatch trigger was therefore unusable from a branch. Runs on a tag
ref keep working — `inputs.tag` is undefined there and resolves to ''.
Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Releaserun dispatched onmainon 2026-07-28 (run 30373084777) failed in the reusable'sValidate inputsstep:workflow_dispatchdeclared no inputs, so there was no way to pass one — the trigger could only ever succeed when dispatched on a tag ref.This adds the
taginput and forwards it tonetresearch/.github/.github/workflows/node-release.yml. On a tag pushinputs.tagis undefined and resolves to'', so the reusable falls back to the ref as before.Separate from this PR:
mainis atchore(release): 2.0.0andpackage.jsonsays2.0.0, but no2.0.0tag exists — the highest tag is1.3.4. The 2.0.0 release still needs its signed tag pushed.