Potential fix for code scanning alert no. 49: Server-side request forgery - #10
Draft
netpersona wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 49: Server-side request forgery#10netpersona wants to merge 1 commit into
netpersona wants to merge 1 commit into
Conversation
…gery Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/netpersona/Luma/security/code-scanning/49
To fix this SSRF problem, strictly validate the
isbnvalue before using it in request URLs. Only allow valid ISBN-10 or ISBN-13 values: this means the string should only contain digits, possibly with a single 'X' at the end for ISBN-10, and no other characters. All other input should be rejected as invalid.The best fix is to add a validation step in
enrichMetadataByIsbn(inserver/metadata.ts), immediately before using the input, that checks that the input is a valid ISBN (using a regular expression). If the string does not match expected ISBN-10 or ISBN-13 patterns after cleaning, the function should throw or return null, and log an error.This will ensure that only well-formed ISBNs are used to construct the Open Library API request URLs, and will prevent path manipulation via malicious input.
You will need to:
isValidIsbn(cleanIsbn: string): booleanto check the pattern (can implement a regex for 10 or 13 digits, optionally ending with 'X' for ISBN-10).enrichMetadataByIsbn, after cleaningisbn, check viaisValidIsbn(cleanIsbn). If invalid, log and return null.No changes are required in
server/routes.tsas the taint is correctly cleaned in theserver/metadata.ts.Suggested fixes powered by Copilot Autofix. Review carefully before merging.