fix(ci): guard Dependabot auto-approval - #24
Merged
Conversation
Keep the repository's one-review rule for human-authored PRs while approving only trusted Dependabot revisions. Align maintenance docs with the live ruleset and required checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Dependabot auto-merge was enabled successfully, but the main-branch ruleset still required one approving review. The workflow waited indefinitely because it enabled auto-merge without submitting a guarded approval.
Security boundary
A human push dismisses the prior revision's approval and fails the trusted-sender guard, so it cannot inherit or refresh the automated approval. The job does not check out or execute pull-request code.
Validation
uv sync --lockeduv run pytest(525 passed, 100% line and branch coverage)uv run pyrightuv run ruff check .uv run pydoclint src/skill_optimizer optimize_description_v2.pyuvx bandit -c pyproject.toml -r src optimize_description_v2.pysourcery review src/skill_optimizer optimize_description_v2.py tests(26 files, no issues)uv run prek run --all-files, including gitleaks, actionlint, and zizmor