Skip to content

Fix probe_mtu() for macOS #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deajan merged 5 commits into from
Feb 15, 2026
Merged

Fix probe_mtu() for macOS #7

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
755cc3c
Fix probe_mtu() for macOS
harmv Feb 12, 2026
11cd010
No timeout on ping6
harmv Feb 12, 2026
175baf4
Review comments pull request
harmv Feb 12, 2026
4e52dd6
Change default interval probe_mtu() to 0.2s
harmv Feb 12, 2026
4d4de81
Add interval param to probe_mtu()
harmv Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions ofunctions/network/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
from ipaddress import IPv4Address, IPv6Address, AddressValueError
import time
import psutil
import platform

from command_runner import command_runner
from requests import get
Expand All @@ -38,6 +39,8 @@
from ofunctions.threading import threaded, wait_for_threaded_result
from ofunctions.misc import BytesConverter

is_macos = platform.system() == 'Darwin'

# python 2.7 compat fixes
try:
from typing import List, Tuple, Union, Iterable, Optional
Expand Down Expand Up @@ -87,7 +90,22 @@ def ping(
targets = ["1.1.1.1", "8.8.8.8", "208.67.222.222"]

def _ping_host(target, retries, source_interface):
if os.name == "nt":
if is_macos:
# -c ...: number of packets to send
# -s ...: packet size to send
# -i ...: interval (s), only root can set less than .2 seconds
# -W ...: timeout (s)
# -I ...: optional source interface name
# -D ...: do not fragment
if ip_type == 6:
command = "ping6 -c 1 -s {} -i {}".format( mtu_encapsulated, interval)
else:
command = "ping -c 1 -s {} -W {} -i {}".format( mtu_encapsulated, timeout, interval )
if do_not_fragment:
Copy link
Copy Markdown
Contributor Author

@harmv harmv Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no -D on ping6

command += " -D"

encoding = "utf-8"
elif os.name == "nt":
# -4/-6: IPType
# -n ...: number of packets to send
# -f: do not fragment
Expand All @@ -106,7 +124,7 @@ def _ping_host(target, retries, source_interface):
# -M do: do not fragment
# -s ...: packet size to send
# -i ...: interval (s), only root can set less than .2 seconds
# -W ...: timeous (s)
# -W ...: timeout (s)
# -I ...: optional source interface name
command = "ping -c 1 -s {} -W {} -i {}".format(
mtu_encapsulated, timeout, interval
Expand All @@ -118,7 +136,7 @@ def _ping_host(target, retries, source_interface):
encoding = "utf-8"

# Add ip_type if specified
if ip_type:
if ip_type and not is_macos:
command += " -{}".format(ip_type)

if source_interface:
Expand Down Expand Up @@ -423,7 +441,7 @@ def get_public_hostname(ip=None):
return None


def probe_mtu(target, method="ICMP", min=1100, max=9000, source_interface=None):
def probe_mtu(target, method="ICMP", min=1100, max=9000, source_interface=None, interval=0.2):
# type: (Union[str, IPv4Address, IPv6Address], str, int, int, str) -> int
"""
Detects MTU to target
Expand Down Expand Up @@ -454,7 +472,7 @@ def probe_mtu(target, method="ICMP", min=1100, max=9000, source_interface=None):
pass

ping_args = [
(target, mtu, 2, 4, 1, ip_type, True, False, source_interface)
(target, mtu, 2, 4, interval, ip_type, True, False, source_interface)
for mtu in range(min, max + 1)
]

Expand Down