Modernization rewrite by pid1 · Pull Request #16 · netdata/ansible

pid1 · 2025-01-08T19:28:58Z

This is an attempt to modernize the Netdata Ansible.

This currently supports Debian, Ubuntu, and OpenSUSE, but additional distributions can be supported easily and in a consistent pattern.

Patches welcome.

Fixes #10
Fixes #7
Fixes #12 via deprecation, though we should handle binary installs gracefully.

Deprecates #8 - I would like to see Molecule tests re-added in the future.

ralphm

@pid1 Here is my preliminary feedback, as discussed.

ralphm · 2025-03-31T11:51:52Z

.github/CODEOWNERS

@@ -1,2 +1,3 @@
-# For the time being, @Ferroin is responsible for everything here.
+# For the time being, @Ferroin is responsible for everything here


This is probably an accidental change.

ralphm · 2025-03-31T12:08:19Z

.gitignore

+.vscode
+hosts
+ansible.cfg
+.swp


I have an ambivalent approach towards .gitignore files in repos, generally opting for a combination of a well maintained ~/.config/git/ignore and project specifc .git/info/exclude in the working tree. On the other hand, our Agent repo has a very extensive one.

That said, if you want to exclude ViM (swap) files, have a look at https://github.com/github/gitignore/blob/main/Global/Vim.gitignore.

I'm equivalently ambivalent about it. This was mainly for my convenience. I'll remove it.

ralphm · 2025-03-31T12:10:48Z

README.md

-# Example of basic Netdata agent management using Ansible
-## Prerequisites
-Tested with Ansible v. 2.12.1; should work with any Ansible version since 2.9
+# Netdata Ansible


At some point, possibly not as part of this PR, but definitely before publishing this to Galaxy, we need to expand this (and also https://learn.netdata.cloud/) with all the current tweakables and expand example usage.

ralphm · 2025-03-31T12:15:22Z

defaults/main.yml

@@ -0,0 +1,43 @@
+---
+role_version: 1.0.0


Possibly we should have 0.x.x here. Let's have 1.0.0 when we do an actual release. I also don't think that information goes here, but in meta/main.yml in a galaxy_info object, or in galaxy.yml?

ralphm · 2025-03-31T12:15:37Z

defaults/main.yml

+role_version: 1.0.0
+
+# Define the Netdata release version we install
+netdata_release_version: "stable"


We call this release channel.

Also, the names we typically use are stable and nightly, but the the native build repos use edge instead of nightly. I think it would be good so be able to put nightly as a value here and it doing the right thing.

@ralphm I'll update this to reflect the release channel terminology.

As for nightly versus stable, I'd suggest considering the target audience for the Ansible versus the command-line installer. The script defaulting to nightly is unexpected and surprising as a user, and I'd certainly be displeased as a sysadmin if Ansible auto-installed a nightly/non-stable version by default.

Happy to be convinced otherwise here.

Oh, I did not mean having nightly as the default. Just that it can take that as a value, instead of, or next to edge.

ralphm · 2025-03-31T13:15:19Z

tasks/node_claim.yml

+    owner: root
+    group: root
+    mode: '0644'
+  notify: Restart Netdata


We don't really need to restart the Agent in order for it to process claim.conf. The Netdata CLI has a reload-claiming-state command that calls a corresponding API in the Agent to just reload its config and (re-)connect to Cloud.

It might be nice to prevent restarting Netdata if we don't need to because of other notify calls.

Ah nice, I didn't realize that occurred. I'll remove the restart.

But add the reload as a handler.

ralphm · 2025-03-31T13:18:43Z

templates/claim.conf.j2

+    {% if netdata_proxy %}
+        proxy = {{ netdata_proxy }}
+    {% endif %}
+    insecure = 'no'


Given that no is the default and we are not making this into a variable, we can do two things:

Just remove it from the template.

Have some kind of dict for other options, like insecure, providing a way to control it.

I'm favoring option 1 right now.

I'll remove that.

ralphm · 2025-03-31T13:21:59Z

tasks/configure-linux.yml

+
+- name: Lay down charts.d.conf
+  ansible.builtin.copy:
+    content: 'enable_all_charts="yes"'


This is the default. Why make this explicit, while not offering any other configuration?

Ah, is this enabled by default without charts.d.conf existing?

ralphm · 2025-03-31T14:03:43Z

tasks/install-ubuntu.yml

@@ -0,0 +1,37 @@
+---


This is identical to install-debian.yml. Can we consolidate, e.g. by using ansible_pkg_mgr?

ralphm · 2025-03-31T14:04:40Z

vars/main.yml

@@ -0,0 +1,2 @@
+---
+# vars file for role


I think we can remove this, if empty.

CLAassistant · 2025-04-01T10:27:48Z

All committers have signed the CLA.

sashwathn · 2025-10-09T05:42:10Z

@agomerz : Can you please sign the CLA?

rawiriblundell · 2026-03-10T21:50:25Z

Hi @agomerz: This PR is blocked, can you please sign the CLA?

Alternatively, @pid1: would you be open to another PR with only your commits cherry-picked?

pid1 · 2026-03-10T22:41:10Z

I’ll do the latter

Remove legacy multi-role structure (roles/, molecule/, claim.yml, purge.yml, netdata-agent.yml, .ansible-lint, group_vars/, host_vars/). Implement single-role layout supporting Debian, Ubuntu, and OpenSUSE with CI workflows for linting and integration testing. Address all review feedback from netdata#16: - Restore trailing period in CODEOWNERS comment - Remove .gitignore per reviewer agreement - Rename netdata_release_version to netdata_release_channel with nightly->edge mapping - Move role version from defaults to meta/main.yml as 0.1.0 - Add explicit GPG key ID to apt_key task - Replace restart handler with netdatacli reload-claiming-state for claims - Remove default insecure=no from claim.conf.j2 - Remove redundant enable_all_charts charts.d.conf task - Consolidate install-ubuntu.yml into install-debian.yml - Remove empty vars/main.yml

The ansible-lint schema[meta] rule does not allow 'version' inside galaxy_info. Move the field to the root level of meta/main.yml to satisfy the reviewer's request while passing lint validation.

pid1 · 2026-03-10T23:15:59Z

@rawiriblundell I've re-implemented this in #18 and addressed the PR feedback. Other feedback welcome and enouraged.

pid1 added 5 commits December 6, 2024 15:36

Delete upstream’s ansible.cfg and host file

a6aca50

Ignore hosts, ansible config. and vscode from Git

0638e38

Make iteration easy

8a9fdd7

Lint fixes

4c70a0e

Fix naming convention, support aarch64

61b1af4

pid1 requested a review from a team as a code owner January 8, 2025 19:28

ralphm mentioned this pull request Jan 22, 2025

Properly maintain this repo #10

Open

6 tasks

ralphm suggested changes Mar 31, 2025

View reviewed changes

Copilot AI mentioned this pull request Nov 25, 2025

Address PR#16 feedback: terminology, consolidation, and security improvements pid1/netdata-ansible#13

Closed

pid1 force-pushed the full-rewrite branch from 7e522a0 to 2a6d58f Compare March 10, 2026 22:59

Fix meta/main.yml: move version to root level for schema compliance

48799f5

The ansible-lint schema[meta] rule does not allow 'version' inside galaxy_info. Move the field to the root level of meta/main.yml to satisfy the reviewer's request while passing lint validation.

pid1 mentioned this pull request Mar 10, 2026

Modernization rewrite V2 #18

Open

pid1 closed this Mar 10, 2026

		@@ -1,2 +1,3 @@
		# For the time being, @Ferroin is responsible for everything here.
		# For the time being, @Ferroin is responsible for everything here

Conversation

pid1 commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ralphm left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CLAassistant commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sashwathn commented Oct 9, 2025

Uh oh!

rawiriblundell commented Mar 10, 2026

Uh oh!

pid1 commented Mar 10, 2026

Uh oh!

pid1 commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pid1 commented Jan 8, 2025 •

edited

Loading

CLAassistant commented Apr 1, 2025 •

edited

Loading