Reduce PowerShell shell approval repetition - #1837
Merged
Merged
Conversation
Aaronontheweb
enabled auto-merge (squash)
August 9, 2026 10:39
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+255
to
+263
| foreach (var argument in occurrence.Clause.Args) | ||
| { | ||
| if (argument.IsPath | ||
| && !string.IsNullOrWhiteSpace(argument.Resolved) | ||
| && IsDeniedAgainst(argument.Resolved, _shellDeniedPaths)) | ||
| { | ||
| return true; | ||
| } | ||
| } |
Comment on lines
+278
to
+282
| foreach (var redirect in occurrence.Redirects) | ||
| { | ||
| if (redirect.IsPathRelevant && DomainReferencesDeniedPath(redirect.Target)) | ||
| return true; | ||
| } |
Comment on lines
+172
to
+175
| catch | ||
| { | ||
| return false; | ||
| } |
Comment on lines
+92
to
+95
| var deniedRoot = Path.Combine( | ||
| Path.GetTempPath(), | ||
| "netclaw-protected-root", | ||
| "config"); |
| Defaults(), | ||
| new ShellCommandPolicy(), | ||
| new ToolPathPolicy([deniedRoot])); | ||
| var decodedPath = Path.Combine(deniedRoot, "secret.txt"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security review
An adversarial reviewer found and verified fixes for Bash-to-PowerShell quote decoding, option-bearing launcher prefixes, and Windows cmd quote removal. The final review passed with no material findings.
Validation