Use the reminder actor clock in the expiry test - #1767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FakeTimeProviderin the expiry test.Cause
PR #1766 exposed this race in the macOS CI job.
The test created
ExpiresAtfromTimeProvider.System. The actor compared that value against its injectedFakeTimeProvider.Clock drift could place the test expiry after the actor's frozen time. The actor then started an execution instead of disabling the reminder.
The fix derives the test time from the same fake clock. It does not increase a timeout or add a delay.
Validation
dotnet slopwatch analyzepassed with zero issues.pwsh ./scripts/Add-FileHeaders.ps1 -Verifypassed.git diff --checkpassed.