Repository navigation
fix(nix): bump cl-parser-kit so its cl-prolog-kit follows resolves - #21
Merged
Merged
Conversation
The rename pass rewrote this repo's follows key from `inputs.cl-parser-kit.inputs.cl-prolog.follows` to `...inputs.cl-prolog-kit.follows` but left cl-parser-kit pinned at v1.1.1, which predates cl-parser-kit's own migration and still names that input `cl-prolog` (flake.nix:52 at that tag). Nix silently ignores a follows targeting an input name that does not exist, so the deduplication was lost without any error: flake.lock carried cl-prolog v1.4.3 as a separate node alongside cl-prolog-kit v1.5.0, and the old repository was still fetched and built on every evaluation. CI stayed green throughout, which is why this survived review -- a broken follows costs a duplicate fetch, not a build failure. Renaming a follows key and bumping the pin it targets are one change, not two: the key names an input in the *other* flake, so it is only valid against a revision where that name exists. Pinned to cl-parser-kit's current main, which carries the migration; its newest tag, v1.1.1, is pre-migration. After the re-lock flake.lock holds exactly one Prolog node, cl-prolog-kit v1.5.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the
-kitrename, found while auditingfollowskeys org-wide.The rename pass rewrote
inputs.cl-parser-kit.inputs.cl-prolog.follows→...inputs.cl-prolog-kit.follows, but leftcl-parser-kitpinned at v1.1.1, which predates cl-parser-kit's own migration and still names that inputcl-prolog(itsflake.nix:52at that tag).Nix silently ignores a follows targeting an input name that does not exist. So the deduplication was lost with no error:
flake.lockcarriedcl-prolog v1.4.3as a separate node alongsidecl-prolog-kit v1.5.0, and the old repository was still being fetched and built on every evaluation.CI stayed green the whole time — a broken follows costs a duplicate fetch, not a build failure. That is why it survived review.
The lesson: renaming a follows key and bumping the pin it targets are one change, not two. The key names an input in the other flake, so it is only valid against a revision where that name exists.
After the re-lock,
flake.lockholds exactly one Prolog node:cl-prolog-kit v1.5.0.