Fix Metashape tangential distortion import - #3779
Open
tianrking wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
p1andp2during XML import.transforms.jsonregression test with distinct coefficients.Closes #3714
Why
Metashape assigns
P1to the(r^2 + 2x^2)term andP2to the2xyterm, while OpenCV assigns those terms top2andp1, respectively. Copying the names directly therefore changes the imported camera distortion.References: Agisoft Metashape 2.3 manual, Camera models and OpenCV camera calibration.
Validation
mainwith0.001 != -0.002, then passes with this change.tests/process_data/test_misc.py: 3 passed.open3denvironment warning).The local test environment did not have Open3D installed, so the unused import was stubbed for these no-point-cloud test paths; CI installs the project dependency set.
AI assistance
AI-assisted repository analysis and test planning were used. I reviewed the final diff and ran the validations above locally.