Skip to content

fix: coerce numpy scalars in colmap write_next_bytes for NumPy 2.x #3774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
f-dy wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

fix: coerce numpy scalars in colmap write_next_bytes for NumPy 2.x #3774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions nerfstudio/data/utils/colmap_parsing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,11 @@ def write_next_bytes(fid, data, format_char_sequence, endian_character="<"):
if isinstance(data, (list, tuple)):
bytes = struct.pack(endian_character + format_char_sequence, *data)
else:
# NumPy 2.x no longer implicitly converts a size-1 ndarray (or a NumPy
# scalar) to a Python scalar inside struct.pack, which raises
# "required argument is not a float/integer". Coerce explicitly.
if isinstance(data, (np.ndarray, np.generic)):
data = data.item()
bytes = struct.pack(endian_character + format_char_sequence, data)
fid.write(bytes)

Expand Down
Loading