Indice changes - #3668
Open
basebala wants to merge 10 commits into
Open
Conversation
added 3 commits
June 15, 2025 18:25
akristoffersen
self-requested a review
July 1, 2025 17:14
akristoffersen
approved these changes
Jul 1, 2025
akristoffersen
left a comment
akristoffersen
left a comment
Contributor
There was a problem hiding this comment.
This is awesome! Seems super useful, thanks for contributing.
| auto_scale_poses: bool = True | ||
| """Whether to automatically scale the poses to fit in +/- 1 bounding box.""" | ||
| eval_mode: Literal["fraction", "filename", "interval", "all"] = "fraction" | ||
| eval_mode: Literal["fraction", "filename", "interval", "all", "indices"] = "fraction" |
Contributor
There was a problem hiding this comment.
Add the indices behavior in the comment below
Updated pip install command for tiny-cuda-nn to include --no-build-isolation.
Updated the Dockerfile to install additional Python packages and upgrade setuptools.
Author
|
@akristoffersen can we merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new eval-mode such that developers can input indices of images from dataset (zero-indexed) manually as the evaluation dataset.
To use, one can use command 'nerfstudio-data --eval-mode indices --eval-image-indices [spaced list of image indices for evaluation]' with their 'ns-train' command.
Any image with an index not specified in --eval-image-indices will be used for training.