fix "ns-render interpolate", so that it can render the input views, add crop box - #2059
Open
f-dy wants to merge 3 commits into
Open
fix "ns-render interpolate", so that it can render the input views, add crop box#2059f-dy wants to merge 3 commits into
f-dy wants to merge 3 commits into
Conversation
…d crop box Previously, ns-render interpolate: - ignored distortion parameters - used an interpolated focal length, but principal point was from the first camera - rendered all images with the same size, even if input views were of different sizes - forgot to render the last frame - There was no default support for crop box and background color, except when rendering from a camera path, where these would exclusively be fetched from the camera_path.json Now: - There is an command-line option `--fixed-intrinsics` to keep fixed intrinsics through the whole sequence, but they are all interpolated by default - Everything is interpolated, even size, so that `ns-render interpolate -step 1` should render exactly the input images - All render modes have the options `--use-bounding-box` `--background-color` `--bounding-box-min` `--bouding-box-max` (same syntax as ns-export), which can override the json settings when rendering a camera path. Works great with the gray colormap from nerfstudio-project#2058 to render object masks.
Contributor
|
This is great! |
Contributor
|
Hi, just checking in on this PR, looking forward to it being incorporated. |
Resolve conflicts in camera_utils.py, camera_paths.py, render.py: - Unify get_interpolated_poses_many to support BOTH main's time interpolation and this PR's widths/heights/dist_coeffs, via index-based pose ordering (get_ordered_pose_indices). - Thread times + sizes + dist_coeffs through get_interpolated_camera_path and set them on the built Cameras. - render.py: adopt main's OrientedBox crop and render_nearest_camera (superseding this PR's AABB crop) and re-apply the PR's fixed_intrinsics option on RenderInterpolated.
f-dy
pushed a commit
to f-dy/nerfstudio
that referenced
this pull request
Jul 28, 2026
Completes the nerfstudio-project#2059 integration: get_interpolated_camera_path requires fixed_intrinsics, but RenderInterpolated neither exposed the flag nor passed it, which would crash 'ns-render interpolate'.
Completes the nerfstudio-project#2059 integration: get_interpolated_camera_path requires fixed_intrinsics, but RenderInterpolated neither exposed the flag nor passed it, which would crash 'ns-render interpolate'.
f-dy
pushed a commit
to f-dy/nerfstudio
that referenced
this pull request
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
ns-render interpolate:Now:
--fixed-intrinsicsto keep fixed intrinsics through the whole sequence, but they are all interpolated by defaultns-render interpolate --interpolation-steps 1should render exactly the input images--use-bounding-box--background-color--bounding-box-min--bouding-box-max(same syntax as ns-export), which can override the json settings when rendering a camera path.Works great with the gray colormap from #2058 to render object masks.