Replace forked pycolmap with official version for examples - #951
Open
ice1080 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version of pycolmap used in the examples folder was a fork that was used to import a
SceneManagerfor reading the cameras, images, and points3D binary (or txt) files from colmap output. This caused issues if a different version of pycolmap was installed (such as the official version), as theSceneManagerdoesn't exist. The official pycolmap repo has aReconstructionclass now for this purpose.Update to the official pycolmap version and use this for loading the cameras, images, and points3D files into usable objects.
I was able to run a successful training (using
simple_trainer.py) with this change.Fixes #830